Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: third_party/WebKit/Source/core/animation/AnimationTestHelper.cpp

Issue 2200303003: Remove v8CallOrCrash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: temp Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/animation/AnimationTestHelper.h" 5 #include "core/animation/AnimationTestHelper.h"
6 6
7 #include "bindings/core/v8/V8Binding.h" 7 #include "bindings/core/v8/V8Binding.h"
8 8
9 namespace blink { 9 namespace blink {
10 10
11 v8::Local<v8::Value> stringToV8Value(String string) 11 v8::Local<v8::Value> stringToV8Value(String string)
12 { 12 {
13 return v8::Local<v8::Value>::Cast(v8String(v8::Isolate::GetCurrent(), string )); 13 return v8::Local<v8::Value>::Cast(v8String(v8::Isolate::GetCurrent(), string ));
14 } 14 }
15 15
16 v8::Local<v8::Value> doubleToV8Value(double number) 16 v8::Local<v8::Value> doubleToV8Value(double number)
17 { 17 {
18 return v8::Local<v8::Value>::Cast(v8::Number::New(v8::Isolate::GetCurrent(), number)); 18 return v8::Local<v8::Value>::Cast(v8::Number::New(v8::Isolate::GetCurrent(), number));
19 } 19 }
20 20
21 void setV8ObjectPropertyAsString(v8::Isolate* isolate, v8::Local<v8::Object> obj ect, String name, String value) 21 void setV8ObjectPropertyAsString(v8::Isolate* isolate, v8::Local<v8::Object> obj ect, String name, String value)
22 { 22 {
23 v8CallOrCrash(object->Set(isolate->GetCurrentContext(), stringToV8Value(name ), stringToV8Value(value))); 23 object->Set(isolate->GetCurrentContext(), stringToV8Value(name), stringToV8V alue(value)).ToChecked();
24 } 24 }
25 25
26 void setV8ObjectPropertyAsNumber(v8::Isolate* isolate, v8::Local<v8::Object> obj ect, String name, double value) 26 void setV8ObjectPropertyAsNumber(v8::Isolate* isolate, v8::Local<v8::Object> obj ect, String name, double value)
27 { 27 {
28 v8CallOrCrash(object->Set(isolate->GetCurrentContext(), stringToV8Value(name ), doubleToV8Value(value))); 28 object->Set(isolate->GetCurrentContext(), stringToV8Value(name), doubleToV8V alue(value)).ToChecked();
29 } 29 }
30 30
31 } // namespace blink 31 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698