third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp - Issue 2200303003: Remove v8CallOrCrash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp

Issue 2200303003: Remove v8CallOrCrash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp

index 237095c1b7f9f2bb8f69d12e246250dbd97cbd57..c67f19ff93455a5a28cc5d71260c66f48628dfcf 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp

@@ -23,7 +23,7 @@ ScriptValue IDBObserverChanges::records(ScriptState* scriptState)

for (const auto& it : m_records) {

v8::Local<v8::String> key = v8String(isolate, m_database->getObjectStoreName(it.key));

v8::Local<v8::Value> value = toV8(it.value, context->Global(), isolate);

- v8CallOrCrash(map->Set(context, key, value));

+ map->Set(context, key, value).ToLocalChecked();

}

return ScriptValue::from(scriptState, map);

}