Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h

Issue 2200303003: Remove v8CallOrCrash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: temp Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 } 84 }
85 85
86 template <typename T> 86 template <typename T>
87 inline bool v8Call(v8::MaybeLocal<T> maybeLocal, v8::Local<T>& outVariable, v8:: TryCatch& tryCatch) 87 inline bool v8Call(v8::MaybeLocal<T> maybeLocal, v8::Local<T>& outVariable, v8:: TryCatch& tryCatch)
88 { 88 {
89 bool success = maybeLocal.ToLocal(&outVariable); 89 bool success = maybeLocal.ToLocal(&outVariable);
90 ASSERT(success || tryCatch.HasCaught()); 90 ASSERT(success || tryCatch.HasCaught());
91 return success; 91 return success;
92 } 92 }
93 93
94 template <typename T>
95 inline T v8CallOrCrash(v8::Maybe<T> maybe)
96 {
97 return maybe.FromJust();
98 }
99
100 template <typename T>
101 inline v8::Local<T> v8CallOrCrash(v8::MaybeLocal<T> maybeLocal)
102 {
103 return maybeLocal.ToLocalChecked();
104 }
105
106 #define V8_CALL(outVariable, handle, methodCall, failureExpression) \ 94 #define V8_CALL(outVariable, handle, methodCall, failureExpression) \
107 do { \ 95 do { \
108 if (handle.IsEmpty() || !v8Call(handle->methodCall, outVariable)) { \ 96 if (handle.IsEmpty() || !v8Call(handle->methodCall, outVariable)) { \
109 failureExpression; \ 97 failureExpression; \
110 } \ 98 } \
111 } while (0) 99 } while (0)
112 100
113 } // namespace blink 101 } // namespace blink
114 102
115 #endif // V8BindingMacros_h 103 #endif // V8BindingMacros_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698