third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp - Issue 2200303003: Remove v8CallOrCrash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp

Issue 2200303003: Remove v8CallOrCrash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8ThrowException.cpp ('k') | third_party/WebKit/Source/core/animation/AnimationTestHelper.cpp » ('j') | third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp

index 1a810a9c7ef0febf748a04a2af890c4de3d93a15..1c6d41ae67e678246577010cb6dcfa4bccd9fb02 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp

@@ -90,9 +90,7 @@ void V8HTMLElement::constructorCustom(

// instead.

v8SetReturnValue(info, wrapper);

- v8CallOrCrash(wrapper->SetPrototype(

- scriptState->context(),

- definition->prototype()));

+ wrapper->SetPrototype(scriptState->context(), definition->prototype()).ToChecked();

}

} // namespace blink