third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h - Issue 2200303003: Remove v8CallOrCrash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h

Issue 2200303003: Remove v8CallOrCrash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h b/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h

index 4a6f1c1c1fa94a556f114997983da87d104a9a7a..49ee1a54a6b5c9b1c75c2bc128c93b154390495a 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h

@@ -82,7 +82,7 @@ public:

// Returns the value of the private property if set, or undefined.

v8::Local<v8::Value> getOrUndefined(v8::Local<v8::Context> context, v8::Local<v8::Object> object) const

{

- return v8CallOrCrash(object->GetPrivate(context, m_privateSymbol));

+ return object->GetPrivate(context, m_privateSymbol).ToLocalChecked();

}

// Returns the value of the private property if set, or an empty handle.