third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp - Issue 2200303003: Remove v8CallOrCrash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp

Issue 2200303003: Remove v8CallOrCrash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp ('K') | « third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp ('k') | third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp b/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp

index bbfc917052e078b816cc3c646fa04c7ed86b20e1..ca69f165054155930f38448de3f1a78276f13cf0 100644

--- a/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp

+++ b/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp

@@ -70,7 +70,7 @@ public:

v8::MaybeLocal<v8::Value> maybeValue = v8UnpackIteratorResult(v.getScriptState(), item.As<v8::Object>(), &done);

if (isTerminating(v.getScriptState()))

return ScriptValue();

- v8::Local<v8::Value> value = v8CallOrCrash(maybeValue);

+ v8::Local<v8::Value> value = maybeValue.ToLocalChecked();

if (done) {

readingContext->onReadDone();

return v;