Remove keyIdentifier.

Remove keyIdentifier.

KeyboardEvent.key and KeyboardEvent.code are the replacements for
KeyboardEvent.keyIdentifier.

Approved intent to remove: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/fqnFyoDCOaA/s4WIxZPqAAAJ

BUG=607349
Committed: https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9
Cr-Commit-Position: refs/heads/master@{#404015}

[dtapuska, 2016-07-04 21:26:53]

dtapuska@chromium.org changed reviewers:
+ creis@chromium.org, dcheng@chromium.org, rbyers@chromium.org,
timvolodine@chromium.org

[dtapuska, 2016-07-04 21:26:54]

PTAL

[dcheng, 2016-07-05 02:02:58]

Mojo changes in this CL LGTM, but I've filed
https://bugs.chromium.org/p/chromium/issues/detail?id=625727 to get rid of this
type converter. Do you mind adding a reference to this? We really ought to do
that sooner rather than later.

[Rick Byers, 2016-07-05 14:03:59]

LGTM with nits

What do you want to do on the M53 branch?  Merging this CL to M53 may be too
risky (eg. we can expect this change might break some Chrome extensions, may
take a couple tries before it can really stick).

Maybe before landing this you should land (then merge) an update to the
deprecation warning to say it will be removed in M54 instead of M53?

https://codereview.chromium.org/2120153003/diff/1/mojo/converters/blink/OWNERS
File mojo/converters/blink/OWNERS (right):

https://codereview.chromium.org/2120153003/diff/1/mojo/converters/blink/OWNER...
mojo/converters/blink/OWNERS:1: per-file *_type_converter*.*=set noparent
no-op edit?

https://codereview.chromium.org/2120153003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (left):

https://codereview.chromium.org/2120153003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Deprecation.cpp:365: case
UseCounter::V8KeyboardEvent_KeyIdentifier_AttributeGetter:
nit: please remove the enum entry in UseCounter.h also (the script that updates
histograms.xml is smart enough to know not to remove deleted entries).

[timvolodine, 2016-07-05 14:45:37]

android_webview/... -- lgtm

[Charlie Reis, 2016-07-06 17:54:43]

content/ LGTM.

[dtapuska, 2016-07-06 18:59:49]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-07-06 18:59:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
timvolodine@chromium.org, creis@chromium.org, dcheng@chromium.org,
rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/2120153003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-06 19:00:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 19:15:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 19:16:01]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dtapuska, 2016-07-06 19:26:30]

dtapuska@chromium.org changed reviewers:
+ rockot@chromium.org

[dtapuska, 2016-07-06 19:26:31]

rockot@chromium.org: Please review changes in 

mojo/converters/blink/OWNERS

[Ken Rockot(use gerrit already), 2016-07-06 19:40:29]

lgtm

[dtapuska, 2016-07-06 20:20:47]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2016-07-06 20:21:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 23:15:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 23:15:33]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dtapuska, 2016-07-06 23:35:15]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2016-07-06 23:36:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 00:35:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-07 00:35:37]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-07 00:37:30]

Description was changed from

==========
Remove keyIdentifier.

KeyboardEvent.key and KeyboardEvent.code are the replacements for
KeyboardEvent.keyIdentifier.

Approved intent to remove:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/fqnFyoDCOaA/s4...

BUG=607349
==========

to

==========
Remove keyIdentifier.

KeyboardEvent.key and KeyboardEvent.code are the replacements for
KeyboardEvent.keyIdentifier.

Approved intent to remove:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/fqnFyoDCOaA/s4...

BUG=607349

Committed: https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9
Cr-Commit-Position: refs/heads/master@{#404015}
==========

[commit-bot: I haz the power, 2016-07-07 00:37:32]

Patchset 2 (id:??) landed as
https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9
Cr-Commit-Position: refs/heads/master@{#404015}