content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 2120153003: Remove keyIdentifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 2120153003: Remove keyIdentifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_key_identifier_3a

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index 6be3c4252eab9f9a0f1de0c8d8f10df5ad09afe5..ed183c47db9180626c9a05106611c4a695f5df42 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -2084,7 +2084,6 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(

if (hasMarkedText_ || oldHasMarkedText || textToBeInserted_.length() > 1) {

NativeWebKeyboardEvent fakeEvent = event;

fakeEvent.windowsKeyCode = 0xE5; // VKEY_PROCESSKEY

- fakeEvent.setKeyIdentifierFromWindowsKeyCode();

fakeEvent.skip_in_browser = true;

widgetHost->ForwardKeyboardEvent(fakeEvent);

// If this key event was handled by the input method, but