Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: content/browser/devtools/protocol/input_handler.cc

Issue 2120153003: Remove keyIdentifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_key_identifier_3a
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/input_handler.cc
diff --git a/content/browser/devtools/protocol/input_handler.cc b/content/browser/devtools/protocol/input_handler.cc
index 7e45f1b343a92e9ffb01f209be956117a74dab76..120314bfcf750b3b00dc4b30c23258873adfac3e 100644
--- a/content/browser/devtools/protocol/input_handler.cc
+++ b/content/browser/devtools/protocol/input_handler.cc
@@ -198,17 +198,6 @@ Response InputHandler::DispatchKeyEvent(
if (is_system_key)
event.isSystemKey = *is_system_key;
- if (key_identifier) {
- if (key_identifier->size() >
- blink::WebKeyboardEvent::keyIdentifierLengthCap) {
- return Response::InvalidParams("Invalid 'keyIdentifier' parameter");
- }
- for (size_t i = 0; i < key_identifier->size(); ++i)
- event.keyIdentifier[i] = (*key_identifier)[i];
- } else if (event.type != blink::WebInputEvent::Char) {
- event.setKeyIdentifierFromWindowsKeyCode();
- }
-
if (code) {
event.domCode = static_cast<int>(
ui::KeycodeConverter::CodeStringToDomCode(*code));

Powered by Google App Engine
This is Rietveld 408576698