Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: components/test_runner/event_sender.cc

Issue 2120153003: Remove keyIdentifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_key_identifier_3a
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/event_sender.cc
diff --git a/components/test_runner/event_sender.cc b/components/test_runner/event_sender.cc
index b3eb652921b264591e976cbc26abd50980006b25..da916753b62250ebbded67f24f1b8ae702692ff8 100644
--- a/components/test_runner/event_sender.cc
+++ b/components/test_runner/event_sender.cc
@@ -1653,8 +1653,6 @@ void EventSender::KeyDown(const std::string& code_str,
event_down.unmodifiedText[0] = text;
}
- event_down.setKeyIdentifierFromWindowsKeyCode();
-
if (event_down.modifiers != 0)
event_down.isSystemKey = IsSystemKeyEvent(event_down);
@@ -1710,11 +1708,6 @@ void EventSender::KeyDown(const std::string& code_str,
if (generate_char) {
WebKeyboardEvent event_char = event_up;
event_char.type = WebInputEvent::Char;
- // keyIdentifier is an empty string, unless the Enter key was pressed.
- // This behavior is not standard (keyIdentifier itself is not even a
- // standard any more), but it matches the actual behavior in Blink.
- if (code != ui::VKEY_RETURN)
- event_char.keyIdentifier[0] = '\0';
HandleInputEventOnViewOrPopup(event_char);
}

Powered by Google App Engine
This is Rietveld 408576698