third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp - Issue 2120153003: Remove keyIdentifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

Issue 2120153003: Remove keyIdentifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_key_identifier_3a

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/tests/KeyboardTest.cpp ('k') | third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp b/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

index 11868dbbbe13ccc3a8ea9af9c4dfb8f2a8a9f4ec..489aac8cca2dbef7fd8742a8713cf48eb2944f31 100644

--- a/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

@@ -54,7 +54,7 @@ namespace blink {

KeyboardEvent* createKeyboardEventWithLocation(KeyboardEvent::KeyLocationCode location)

{

- return KeyboardEvent::create("keydown", true, true, 0, "", "", "", location, PlatformEvent::NoModifiers, 0);

+ return KeyboardEvent::create("keydown", true, true, 0, "", "", location, PlatformEvent::NoModifiers, 0);

}

int getModifiersForKeyLocationCode(KeyboardEvent::KeyLocationCode location)