content/browser/renderer_host/input/web_input_event_builders_win.cc - Issue 2120153003: Remove keyIdentifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/web_input_event_builders_win.cc

Issue 2120153003: Remove keyIdentifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_key_identifier_3a

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/web_input_event_builders_mac.mm ('k') | content/browser/renderer_host/native_web_keyboard_event_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/web_input_event_builders_win.cc

diff --git a/content/browser/renderer_host/input/web_input_event_builders_win.cc b/content/browser/renderer_host/input/web_input_event_builders_win.cc

index aa85ebf41f7525bf742b316a865a8a8a70c69db2..51f64e6ed9b8d6ddf6fd3bc0b0bb23973baaf188 100644

--- a/content/browser/renderer_host/input/web_input_event_builders_win.cc

+++ b/content/browser/renderer_host/input/web_input_event_builders_win.cc

@@ -62,8 +62,6 @@ WebKeyboardEvent WebKeyboardEventBuilder::Build(HWND hwnd,

result.text[0] = result.windowsKeyCode;

result.unmodifiedText[0] = result.windowsKeyCode;

}

- result.setKeyIdentifierFromWindowsKeyCode();

result.modifiers =

ui::EventFlagsToWebEventModifiers(ui::GetModifiersFromKeyState());

// NOTE: There doesn't seem to be a way to query the mouse button state in