Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: third_party/WebKit/Source/core/events/KeyboardEvent.h

Issue 2120153003: Remove keyIdentifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_key_identifier_3a
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/KeyboardEvent.h
diff --git a/third_party/WebKit/Source/core/events/KeyboardEvent.h b/third_party/WebKit/Source/core/events/KeyboardEvent.h
index c1f974563cde917508a140e70c3a447921bea5d6..dbe10ae16052a58039c6227c270ce9708f003c1d 100644
--- a/third_party/WebKit/Source/core/events/KeyboardEvent.h
+++ b/third_party/WebKit/Source/core/events/KeyboardEvent.h
@@ -56,11 +56,10 @@ public:
static KeyboardEvent* create(ScriptState*, const AtomicString& type, const KeyboardEventInit&);
- static KeyboardEvent* create(const AtomicString& type, bool canBubble, bool cancelable, AbstractView* view,
- const String& keyIdentifier, const String& code, const String& key, unsigned location,
+ static KeyboardEvent* create(const AtomicString& type, bool canBubble, bool cancelable, AbstractView* view, const String& code, const String& key, unsigned location,
PlatformEvent::Modifiers modifiers, double platformTimeStamp)
{
- return new KeyboardEvent(type, canBubble, cancelable, view, keyIdentifier, code, key, location,
+ return new KeyboardEvent(type, canBubble, cancelable, view, code, key, location,
modifiers, platformTimeStamp);
}
@@ -70,7 +69,6 @@ public:
const String& keyIdentifier, unsigned location,
bool ctrlKey, bool altKey, bool shiftKey, bool metaKey);
- const String& keyIdentifier() const { return m_keyIdentifier; }
const String& code() const { return m_code; }
const String& key() const { return m_key; }
@@ -93,13 +91,12 @@ private:
KeyboardEvent(const PlatformKeyboardEvent&, AbstractView*);
KeyboardEvent(const AtomicString&, const KeyboardEventInit&);
KeyboardEvent(const AtomicString& type, bool canBubble, bool cancelable, AbstractView*,
- const String& keyIdentifier, const String& code, const String& key, unsigned location,
+ const String& code, const String& key, unsigned location,
PlatformEvent::Modifiers, double platformTimeStamp);
void initLocationModifiers(unsigned location);
std::unique_ptr<PlatformKeyboardEvent> m_keyEvent;
- String m_keyIdentifier;
String m_code;
String m_key;
unsigned m_location;

Powered by Google App Engine
This is Rietveld 408576698