Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: third_party/WebKit/LayoutTests/fast/events/key-events-in-input-button.html

Issue 2120153003: Remove keyIdentifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_key_identifier_3a
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/events/key-events-in-input-button.html
diff --git a/third_party/WebKit/LayoutTests/fast/events/key-events-in-input-button.html b/third_party/WebKit/LayoutTests/fast/events/key-events-in-input-button.html
index c03eee49c081d3407bee8d4dc5a8d4f0299d3c33..45e63b7b558d324c084e79158c9fdc9f35d7ca22 100644
--- a/third_party/WebKit/LayoutTests/fast/events/key-events-in-input-button.html
+++ b/third_party/WebKit/LayoutTests/fast/events/key-events-in-input-button.html
@@ -23,8 +23,8 @@ function eventInfo(event, where) {
else if (event.type == "keydown" || event.type == "keypress" || event.type == "keyup")
return (where ? "(" + where + ") " : "") + target.tagName + " - " + event.type
+ ' - ' + [event.ctrlKey, event.altKey, event.shiftKey, event.metaKey]
- + ' - ' + event.keyIdentifier
- + ' - ' + event.keyCode
+ + ' -' + event.key
+ + '- ' + event.keyCode
+ ' - ' + event.charCode;
else if (event.type == "mousedown" || event.type == "click" || event.type == "mouseup")
return (where ? "(" + where + ") " : "") + target.tagName + " - " + event.type;
@@ -34,7 +34,7 @@ function eventInfo(event, where) {
}
}
log("target - type - " + ["ctrlKey", "altKey", "shiftKey", "metaKey"]
- + ' - ' + "keyIdentifier"
+ + ' - ' + "key"
+ ' - ' + "keyCode"
+ ' - ' + "charCode");
@@ -48,7 +48,7 @@ if (window.testRunner) {
log("Space:");
eventSender.keyDown(" ", []);
log("Enter:");
- eventSender.keyDown("\r", []);
+ eventSender.keyDown("Enter", []);
log("A:");
eventSender.keyDown("A", []);
}

Powered by Google App Engine
This is Rietveld 408576698