Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: content/renderer/pepper/event_conversion.cc

Issue 2120153003: Remove keyIdentifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_key_identifier_3a
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/browser_test_utils.cc ('k') | mojo/converters/blink/OWNERS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/event_conversion.cc
diff --git a/content/renderer/pepper/event_conversion.cc b/content/renderer/pepper/event_conversion.cc
index ddafccc4a270380348ca46b79c2d9e896dc020c4..142de441f7b0864c8b34772c6386d67871cc2d3f 100644
--- a/content/renderer/pepper/event_conversion.cc
+++ b/content/renderer/pepper/event_conversion.cc
@@ -380,7 +380,6 @@ WebKeyboardEvent* BuildKeyEvent(const InputEventData& event) {
key_event->timeStampSeconds = event.event_time_stamp;
key_event->modifiers = event.event_modifiers;
key_event->windowsKeyCode = event.key_code;
- key_event->setKeyIdentifierFromWindowsKeyCode();
return key_event;
}
@@ -697,8 +696,6 @@ std::vector<std::unique_ptr<WebInputEvent>> CreateSimulatedWebInputEvents(
key_down_event->text[0] = text;
key_down_event->unmodifiedText[0] = text;
}
- // Convert the key code to a string identifier.
- key_down_event->setKeyIdentifierFromWindowsKeyCode();
*key_up_event = *web_char_event = *key_down_event;
@@ -706,7 +703,6 @@ std::vector<std::unique_ptr<WebInputEvent>> CreateSimulatedWebInputEvents(
if (generate_char) {
web_char_event->type = WebInputEvent::Char;
- web_char_event->keyIdentifier[0] = '\0';
events.push_back(std::move(original_event));
}
« no previous file with comments | « content/public/test/browser_test_utils.cc ('k') | mojo/converters/blink/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698