Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

Issue 2120153003: Remove keyIdentifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_key_identifier_3a
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
diff --git a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
index 6eccd285e34f85ef0ce873884ed56422ffcb8ff1..3130bbc60955d89ac6bf15b7642db24378eda69b 100644
--- a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
+++ b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
@@ -634,7 +634,6 @@ WebInspector.ExtensionServer.prototype = {
// Fool around closure compiler -- it has its own notion of both KeyboardEvent constructor
// and initKeyboardEvent methods and overriding these in externs.js does not have effect.
var event = new window.KeyboardEvent(entry.eventType, {
- keyIdentifier: entry.keyIdentifier,
key: entry.key,
code: entry.code,
keyCode: entry.keyCode,
@@ -653,9 +652,8 @@ WebInspector.ExtensionServer.prototype = {
var keyCode = entry.keyCode;
if (!keyCode) {
// This is required only for synthetic events (e.g. dispatched in tests).
- var match = entry.keyIdentifier.match(/^U\+([\dA-Fa-f]+)$/);
- if (match)
- keyCode = parseInt(match[1], 16);
+ if (entry.key === "Escape")
+ keyCode = 27;
}
return keyCode || 0;
}
« no previous file with comments | « third_party/WebKit/Source/core/frame/Deprecation.cpp ('k') | third_party/WebKit/Source/platform/PlatformKeyboardEvent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698