Don't use deprecated ListValue::Append(Value*) overload.

Don't use deprecated ListValue::Append(Value*) overload.

Fixes for //chrome/browser/ui/webui and its dependencies.

BUG=581865
Committed: https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167
Cr-Commit-Position: refs/heads/master@{#401091}

[dcheng, 2016-06-21 00:07:57]

dcheng@chromium.org changed reviewers:
+ dbeam@chromium.org, mmenke@chromium.org, xhwang@chromium.org

[dcheng, 2016-06-21 00:07:58]

+dbeam for webui changes
+xhwang for content changes
+mmenke for net changes

pretty straightforward, but ends up being an odd subset of code due to the
dependencies of //chrome/browser/ui/webui as well as what depends on its
dependencies.

https://codereview.chromium.org/2086763002/diff/1/chrome/browser/ui/webui/cer...
File chrome/browser/ui/webui/certificate_viewer_webui.cc (right):

https://codereview.chromium.org/2086763002/diff/1/chrome/browser/ui/webui/cer...
chrome/browser/ui/webui/certificate_viewer_webui.cc:299:
base::WrapUnique(node_details = new base::DictionaryValue()));
This is somewhat unsatisfactory, but I'd rather someone who's actually familiar
with this code provide a real fix: I'm not familiar with testing this, nor is
this particularly good documentation for what the built dictionary should look
like. So for now... bandaid.

[eroman, 2016-06-21 00:21:48]

eroman@chromium.org changed reviewers:
+ eroman@chromium.org

[eroman, 2016-06-21 00:21:49]

//net LGTM

[Dan Beam, 2016-06-21 00:48:05]

dbeam@chromium.org changed reviewers:
+ flackr@chromium.org

[Dan Beam, 2016-06-21 00:48:06]

+flackr@: do you mind the proposed bandaid in certificate_viewer_webui.cc?[1] 
do you have a prettier or better suggestion?

[1] i see you added this code here:
https://codereview.chromium.org/7528027/diff/14001/chrome/browser/ui/webui/ce...

https://codereview.chromium.org/2086763002/diff/1/chrome/browser/ui/webui/cer...
File chrome/browser/ui/webui/certificate_viewer_webui.cc (right):

https://codereview.chromium.org/2086763002/diff/1/chrome/browser/ui/webui/cer...
chrome/browser/ui/webui/certificate_viewer_webui.cc:299:
base::WrapUnique(node_details = new base::DictionaryValue()));
On 2016/06/21 00:07:58, dcheng wrote:
> This is somewhat unsatisfactory, but I'd rather someone who's actually
familiar
> with this code provide a real fix: I'm not familiar with testing this, nor is
> this particularly good documentation for what the built dictionary should look
> like. So for now... bandaid.

+flackr

[Dan Beam, 2016-06-21 00:54:12]

otherwise lgtm

https://codereview.chromium.org/2086763002/diff/1/chrome/browser/ui/webui/ide...
File chrome/browser/ui/webui/identity_internals_ui.cc (right):

https://codereview.chromium.org/2086763002/diff/1/chrome/browser/ui/webui/ide...
chrome/browser/ui/webui/identity_internals_ui.cc:10: #include <utility>
what's this for?  i don't see a std::move() in this file

https://codereview.chromium.org/2086763002/diff/1/chrome/browser/ui/webui/net...
File chrome/browser/ui/webui/net_internals/net_internals_ui.cc (right):

https://codereview.chromium.org/2086763002/diff/1/chrome/browser/ui/webui/net...
chrome/browser/ui/webui/net_internals/net_internals_ui.cc:10: #include <list>
#include <memory>

https://codereview.chromium.org/2086763002/diff/1/content/browser/media/media...
File content/browser/media/media_internals_proxy.cc (right):

https://codereview.chromium.org/2086763002/diff/1/content/browser/media/media...
content/browser/media/media_internals_proxy.cc:7: #include <stddef.h>
#include <utility>

[xhwang, 2016-06-21 02:31:28]

content/browser/media/* lgtm % existing nits

[dcheng, 2016-06-21 18:56:02]

https://codereview.chromium.org/2086763002/diff/1/chrome/browser/ui/webui/ide...
File chrome/browser/ui/webui/identity_internals_ui.cc (right):

https://codereview.chromium.org/2086763002/diff/1/chrome/browser/ui/webui/ide...
chrome/browser/ui/webui/identity_internals_ui.cc:10: #include <utility>
On 2016/06/21 00:54:12, Dan Beam wrote:
> what's this for?  i don't see a std::move() in this file

No clue. I'm guessing I needed it in an earlier iteration of the mega patch and
found a different way to rewrite the code that doesn't need it?

In any case, removed.

https://codereview.chromium.org/2086763002/diff/1/chrome/browser/ui/webui/net...
File chrome/browser/ui/webui/net_internals/net_internals_ui.cc (right):

https://codereview.chromium.org/2086763002/diff/1/chrome/browser/ui/webui/net...
chrome/browser/ui/webui/net_internals/net_internals_ui.cc:10: #include <list>
On 2016/06/21 00:54:12, Dan Beam wrote:
> #include <memory>

Done.

https://codereview.chromium.org/2086763002/diff/1/content/browser/media/media...
File content/browser/media/media_internals_proxy.cc (right):

https://codereview.chromium.org/2086763002/diff/1/content/browser/media/media...
content/browser/media/media_internals_proxy.cc:7: #include <stddef.h>
On 2016/06/21 00:54:12, Dan Beam wrote:
> #include <utility>

Done.

[dcheng, 2016-06-21 18:56:10]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-06-21 18:56:11]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org,
xhwang@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2086763002/#ps20001
(title: ".")

[commit-bot: I haz the power, 2016-06-21 18:56:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2086763002/20001

[commit-bot: I haz the power, 2016-06-21 20:25:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-21 20:27:36]

Description was changed from

==========
Don't use deprecated ListValue::Append(Value*) overload.

Fixes for //chrome/browser/ui/webui and its dependencies.

BUG=581865
==========

to

==========
Don't use deprecated ListValue::Append(Value*) overload.

Fixes for //chrome/browser/ui/webui and its dependencies.

BUG=581865

Committed: https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167
Cr-Commit-Position: refs/heads/master@{#401091}
==========

[commit-bot: I haz the power, 2016-06-21 20:27:38]

Patchset 2 (id:??) landed as
https://crrev.com/53a55db87aab3043556fb11e52148b6e43603167
Cr-Commit-Position: refs/heads/master@{#401091}