content/browser/media/media_internals_proxy.h - Issue 2086763002: Don't use deprecated ListValue::Append(Value*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/media_internals_proxy.h

Issue 2086763002: Don't use deprecated ListValue::Append(Value*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc ('k') | content/browser/media/media_internals_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/media_internals_proxy.h

diff --git a/content/browser/media/media_internals_proxy.h b/content/browser/media/media_internals_proxy.h

index 84b4a1b1aad132f067be901c8022a437800c0ed2..c506fc52a0e1910db62b63e533840637cc7f2eeb 100644

--- a/content/browser/media/media_internals_proxy.h

+++ b/content/browser/media/media_internals_proxy.h

@@ -5,6 +5,8 @@

#ifndef CONTENT_BROWSER_MEDIA_MEDIA_INTERNALS_PROXY_H_

#define CONTENT_BROWSER_MEDIA_MEDIA_INTERNALS_PROXY_H_

+#include <memory>

#include "base/macros.h"

#include "base/memory/ref_counted.h"

#include "base/sequenced_task_runner_helpers.h"

@@ -68,7 +70,7 @@ class MediaInternalsProxy

void UpdateUIOnUIThread(const base::string16& update);

// Put |entry| on a list of events to be sent to the page.

- void AddNetEventOnUIThread(base::Value* entry);

+ void AddNetEventOnUIThread(std::unique_ptr<base::Value> entry);

// Send all pending events to the page.

void SendNetEventsOnUIThread();