Don't use deprecated ListValue::Append(Value*) overload.

chrome/browser/ui/webui/certificate_viewer_webui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/certificate_viewer_webui.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/i18n/time_formatting.h"
 #include "base/json/json_writer.h"
+#include "base/memory/ptr_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/certificate_viewer.h"
 #include "chrome/browser/platform_util.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/certificate_dialogs.h"
 #include "chrome/browser/ui/webui/certificate_viewer_ui.h"
 #include "chrome/browser/ui/webui/constrained_web_dialog_ui.h"
 #include "chrome/common/net/x509_certificate_model.h"
 #include "chrome/common/url_constants.h"
@@ skipping 263 matching lines @@
   int cert_index = GetCertificateIndex(args);
   if (cert_index < 0)
     return;
 
   net::X509Certificate::OSCertHandle cert = cert_chain_[cert_index];
 
   base::ListValue root_list;
   base::DictionaryValue* node_details;
   base::DictionaryValue* alt_node_details;
   base::ListValue* cert_sub_fields;
-  root_list.Append(node_details = new base::DictionaryValue());
+  root_list.Append(
+      base::WrapUnique(node_details = new base::DictionaryValue()));

[dcheng, 2016/06/21 00:07:58]

This is somewhat unsatisfactory, but I'd rather someone who's actually familiar
with this code provide a real fix: I'm not familiar with testing this, nor is
this particularly good documentation for what the built dictionary should look
like. So for now... bandaid.

[Dan Beam, 2016/06/21 00:48:06]

+flackr

   node_details->SetString("label", x509_certificate_model::GetTitle(cert));
 
   base::ListValue* cert_fields;
   node_details->Set("children", cert_fields = new base::ListValue());
-  cert_fields->Append(node_details = new base::DictionaryValue());
+  cert_fields->Append(
+      base::WrapUnique(node_details = new base::DictionaryValue()));
 
   node_details->SetString("label",
       l10n_util::GetStringUTF8(IDS_CERT_DETAILS_CERTIFICATE));
   node_details->Set("children", cert_fields = new base::ListValue());
 
   // Main certificate fields.
-  cert_fields->Append(node_details = new base::DictionaryValue());
+  cert_fields->Append(
+      base::WrapUnique(node_details = new base::DictionaryValue()));
   node_details->SetString("label",
       l10n_util::GetStringUTF8(IDS_CERT_DETAILS_VERSION));
   std::string version = x509_certificate_model::GetVersion(cert);
   if (!version.empty())
     node_details->SetString("payload.val",
         l10n_util::GetStringFUTF8(IDS_CERT_DETAILS_VERSION_FORMAT,
                                   base::UTF8ToUTF16(version)));
 
-  cert_fields->Append(node_details = new base::DictionaryValue());
+  cert_fields->Append(
+      base::WrapUnique(node_details = new base::DictionaryValue()));
   node_details->SetString("label",
       l10n_util::GetStringUTF8(IDS_CERT_DETAILS_SERIAL_NUMBER));
   node_details->SetString("payload.val",
       x509_certificate_model::GetSerialNumberHexified(cert,
           l10n_util::GetStringUTF8(IDS_CERT_INFO_FIELD_NOT_PRESENT)));
 
-  cert_fields->Append(node_details = new base::DictionaryValue());
+  cert_fields->Append(
+      base::WrapUnique(node_details = new base::DictionaryValue()));
   node_details->SetString("label",
       l10n_util::GetStringUTF8(IDS_CERT_DETAILS_CERTIFICATE_SIG_ALG));
   node_details->SetString("payload.val",
       x509_certificate_model::ProcessSecAlgorithmSignature(cert));
 
-  cert_fields->Append(node_details = new base::DictionaryValue());
+  cert_fields->Append(
+      base::WrapUnique(node_details = new base::DictionaryValue()));
   node_details->SetString("label",
       l10n_util::GetStringUTF8(IDS_CERT_DETAILS_ISSUER));
   node_details->SetString("payload.val",
       x509_certificate_model::GetIssuerName(cert));
 
   // Validity period.
-  cert_fields->Append(node_details = new base::DictionaryValue());
+  cert_fields->Append(
+      base::WrapUnique(node_details = new base::DictionaryValue()));
   node_details->SetString("label",
       l10n_util::GetStringUTF8(IDS_CERT_DETAILS_VALIDITY));
 
   node_details->Set("children", cert_sub_fields = new base::ListValue());
-  cert_sub_fields->Append(node_details = new base::DictionaryValue());
+  cert_sub_fields->Append(
+      base::WrapUnique(node_details = new base::DictionaryValue()));
   node_details->SetString("label",
       l10n_util::GetStringUTF8(IDS_CERT_DETAILS_NOT_BEFORE));
-  cert_sub_fields->Append(alt_node_details = new base::DictionaryValue());
+  cert_sub_fields->Append(
+      base::WrapUnique(alt_node_details = new base::DictionaryValue()));
   alt_node_details->SetString("label",
       l10n_util::GetStringUTF8(IDS_CERT_DETAILS_NOT_AFTER));
   base::Time issued, expires;
   if (x509_certificate_model::GetTimes(cert, &issued, &expires)) {
     node_details->SetString(
         "payload.val",
         base::UTF16ToUTF8(
             base::TimeFormatShortDateAndTimeWithTimeZone(issued)));
     alt_node_details->SetString(
         "payload.val",
         base::UTF16ToUTF8(
             base::TimeFormatShortDateAndTimeWithTimeZone(expires)));
   }
 
-  cert_fields->Append(node_details = new base::DictionaryValue());
+  cert_fields->Append(
+      base::WrapUnique(node_details = new base::DictionaryValue()));
   node_details->SetString("label",
       l10n_util::GetStringUTF8(IDS_CERT_DETAILS_SUBJECT));
   node_details->SetString("payload.val",
       x509_certificate_model::GetSubjectName(cert));
 
   // Subject key information.
-  cert_fields->Append(node_details = new base::DictionaryValue());
+  cert_fields->Append(
+      base::WrapUnique(node_details = new base::DictionaryValue()));
   node_details->SetString("label",
       l10n_util::GetStringUTF8(IDS_CERT_DETAILS_SUBJECT_KEY_INFO));
 
   node_details->Set("children", cert_sub_fields = new base::ListValue());
-  cert_sub_fields->Append(node_details = new base::DictionaryValue());
+  cert_sub_fields->Append(
+      base::WrapUnique(node_details = new base::DictionaryValue()));
   node_details->SetString("label",
       l10n_util::GetStringUTF8(IDS_CERT_DETAILS_SUBJECT_KEY_ALG));
   node_details->SetString("payload.val",
       x509_certificate_model::ProcessSecAlgorithmSubjectPublicKey(cert));
-  cert_sub_fields->Append(node_details = new base::DictionaryValue());
+  cert_sub_fields->Append(
+      base::WrapUnique(node_details = new base::DictionaryValue()));
   node_details->SetString("label",
       l10n_util::GetStringUTF8(IDS_CERT_DETAILS_SUBJECT_KEY));
   node_details->SetString("payload.val",
       x509_certificate_model::ProcessSubjectPublicKeyInfo(cert));
 
   // Extensions.
   x509_certificate_model::Extensions extensions;
   x509_certificate_model::GetExtensions(
       l10n_util::GetStringUTF8(IDS_CERT_EXTENSION_CRITICAL),
       l10n_util::GetStringUTF8(IDS_CERT_EXTENSION_NON_CRITICAL),
       cert, &extensions);
 
   if (!extensions.empty()) {
-    cert_fields->Append(node_details = new base::DictionaryValue());
+    cert_fields->Append(
+        base::WrapUnique(node_details = new base::DictionaryValue()));
     node_details->SetString("label",
         l10n_util::GetStringUTF8(IDS_CERT_DETAILS_EXTENSIONS));
 
     node_details->Set("children", cert_sub_fields = new base::ListValue());
     for (x509_certificate_model::Extensions::const_iterator i =
          extensions.begin(); i != extensions.end(); ++i) {
-      cert_sub_fields->Append(node_details = new base::DictionaryValue());
+      cert_sub_fields->Append(
+          base::WrapUnique(node_details = new base::DictionaryValue()));
       node_details->SetString("label", i->name);
       node_details->SetString("payload.val", i->value);
     }
   }
 
-  cert_fields->Append(node_details = new base::DictionaryValue());
+  cert_fields->Append(
+      base::WrapUnique(node_details = new base::DictionaryValue()));
   node_details->SetString("label",
       l10n_util::GetStringUTF8(IDS_CERT_DETAILS_CERTIFICATE_SIG_ALG));
   node_details->SetString("payload.val",
       x509_certificate_model::ProcessSecAlgorithmSignatureWrap(cert));
 
-  cert_fields->Append(node_details = new base::DictionaryValue());
+  cert_fields->Append(
+      base::WrapUnique(node_details = new base::DictionaryValue()));
   node_details->SetString("label",
       l10n_util::GetStringUTF8(IDS_CERT_DETAILS_CERTIFICATE_SIG_VALUE));
   node_details->SetString("payload.val",
       x509_certificate_model::ProcessRawBitsSignatureWrap(cert));
 
-  cert_fields->Append(node_details = new base::DictionaryValue());
+  cert_fields->Append(
+      base::WrapUnique(node_details = new base::DictionaryValue()));
   node_details->SetString("label",
       l10n_util::GetStringUTF8(IDS_CERT_INFO_FINGERPRINTS_GROUP));
   node_details->Set("children", cert_sub_fields = new base::ListValue());
 
-  cert_sub_fields->Append(node_details = new base::DictionaryValue());
+  cert_sub_fields->Append(
+      base::WrapUnique(node_details = new base::DictionaryValue()));
   node_details->SetString("label",
       l10n_util::GetStringUTF8(IDS_CERT_INFO_SHA256_FINGERPRINT_LABEL));
   node_details->SetString("payload.val",
       x509_certificate_model::HashCertSHA256(cert));
-  cert_sub_fields->Append(node_details = new base::DictionaryValue());
+  cert_sub_fields->Append(
+      base::WrapUnique(node_details = new base::DictionaryValue()));
   node_details->SetString("label",
       l10n_util::GetStringUTF8(IDS_CERT_INFO_SHA1_FINGERPRINT_LABEL));
   node_details->SetString("payload.val",
       x509_certificate_model::HashCertSHA1(cert));
 
   // Send certificate information to javascript.
   web_ui()->CallJavascriptFunctionUnsafe("cert_viewer.getCertificateFields",
                                          root_list);
 }
 
 int CertificateViewerDialogHandler::GetCertificateIndex(
     const base::ListValue* args) const {
   int cert_index;
   double val;
   if (!(args->GetDouble(0, &val)))
     return -1;
   cert_index = static_cast<int>(val);
   if (cert_index < 0 || cert_index >= static_cast<int>(cert_chain_.size()))
     return -1;
   return cert_index;
 }