Don't use deprecated ListValue::Append(Value*) overload.

chrome/browser/ui/webui/net_internals/net_internals_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/net_internals/net_internals_ui.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <list>

[Dan Beam, 2016/06/21 00:54:12]

#include <memory>

[dcheng, 2016/06/21 18:56:01]

Done.

 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/files/file.h"
 #include "base/files/file_path.h"
@@ skipping 299 matching lines @@
   friend class base::DeleteHelper<IOThreadImpl>;
 
   typedef std::list<scoped_refptr<net::URLRequestContextGetter> >
       ContextGetterList;
 
   ~IOThreadImpl() override;
 
   // Adds |entry| to the queue of pending log entries to be sent to the page via
   // Javascript.  Must be called on the IO Thread.  Also creates a delayed task
   // that will call PostPendingEntries, if there isn't one already.
-  void AddEntryToQueue(base::Value* entry);
+  void AddEntryToQueue(std::unique_ptr<base::Value> entry);
 
   // Sends all pending entries to the page via Javascript, and clears the list
   // of pending entries.  Sending multiple entries at once results in a
   // significant reduction of CPU usage when a lot of events are happening.
   // Must be called on the IO Thread.
   void PostPendingEntries();
 
   // Adds entries with the states of ongoing URL requests.
   void PrePopulateEventList();
 
@@ skipping 239 matching lines @@
   extensions::ExtensionSystem* extension_system =
       extensions::ExtensionSystem::Get(profile);
   if (extension_system) {
     ExtensionService* extension_service = extension_system->extension_service();
     if (extension_service) {
       std::unique_ptr<const extensions::ExtensionSet> extensions(
           extensions::ExtensionRegistry::Get(profile)
               ->GenerateInstalledExtensionsSet());
       for (extensions::ExtensionSet::const_iterator it = extensions->begin();
            it != extensions->end(); ++it) {
-        base::DictionaryValue* extension_info = new base::DictionaryValue();
+        std::unique_ptr<base::DictionaryValue> extension_info(
+            new base::DictionaryValue());
         bool enabled = extension_service->IsExtensionEnabled((*it)->id());
-        extensions::GetExtensionBasicInfo(it->get(), enabled, extension_info);
-        extension_list->Append(extension_info);
+        extensions::GetExtensionBasicInfo(it->get(), enabled,
+                                          extension_info.get());
+        extension_list->Append(std::move(extension_info));
       }
     }
   }
 #endif
   SendJavascriptCommand("receivedExtensionInfo", extension_list);
 }
 
 void NetInternalsMessageHandler::OnGetDataReductionProxyInfo(
     const base::ListValue* list) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
@@ skipping 490 matching lines @@
     NOTREACHED();
   }
 
   net_log()->SetObserverCaptureMode(this, mode);
 }
 
 // Note that unlike other methods of IOThreadImpl, this function
 // can be called from ANY THREAD.
 void NetInternalsMessageHandler::IOThreadImpl::OnAddEntry(
     const net::NetLog::Entry& entry) {
-  BrowserThread::PostTask(
-      BrowserThread::IO, FROM_HERE,
-      base::Bind(&IOThreadImpl::AddEntryToQueue, this, entry.ToValue()));
+  BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
+                          base::Bind(&IOThreadImpl::AddEntryToQueue, this,
+                                     base::Passed(entry.ToValue())));
 }
 
 // Note that this can be called from ANY THREAD.
 void NetInternalsMessageHandler::IOThreadImpl::SendJavascriptCommand(
     const std::string& command,
     base::Value* arg) {
   if (BrowserThread::CurrentlyOn(BrowserThread::UI)) {
     if (handler_.get() && !was_webui_deleted_) {
       // We check |handler_| in case it was deleted on the UI thread earlier
       // while we were running on the IO thread.
       handler_->SendJavascriptCommand(command, arg);
     } else {
       delete arg;
     }
     return;
   }
 
   if (!BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       base::Bind(&IOThreadImpl::SendJavascriptCommand, this, command, arg))) {
     // Failed posting the task, avoid leaking.
     delete arg;
   }
 }
 
 void NetInternalsMessageHandler::IOThreadImpl::AddEntryToQueue(
-    base::Value* entry) {
+    std::unique_ptr<base::Value> entry) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   if (!pending_entries_.get()) {
     pending_entries_.reset(new base::ListValue());
     BrowserThread::PostDelayedTask(
         BrowserThread::IO, FROM_HERE,
         base::Bind(&IOThreadImpl::PostPendingEntries, this),
         base::TimeDelta::FromMilliseconds(kNetLogEventDelayMilliseconds));
   }
-  pending_entries_->Append(entry);
+  pending_entries_->Append(std::move(entry));
 }
 
 void NetInternalsMessageHandler::IOThreadImpl::PostPendingEntries() {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   if (pending_entries_.get())
     SendJavascriptCommand("receivedLogEntries", pending_entries_.release());
 }
 
 void NetInternalsMessageHandler::IOThreadImpl::PrePopulateEventList() {
   // Using a set removes any duplicates.
@@ skipping 26 matching lines @@
 ////////////////////////////////////////////////////////////////////////////////
 
 NetInternalsUI::NetInternalsUI(content::WebUI* web_ui)
     : WebUIController(web_ui) {
   web_ui->AddMessageHandler(new NetInternalsMessageHandler());
 
   // Set up the chrome://net-internals/ source.
   Profile* profile = Profile::FromWebUI(web_ui);
   content::WebUIDataSource::Add(profile, CreateNetInternalsHTMLSource());
 }