Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Side by Side Diff: chrome/browser/ui/webui/options/search_engine_manager_handler.h

Issue 2086763002: Don't use deprecated ListValue::Append(Value*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_SEARCH_ENGINE_MANAGER_HANDLER_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_SEARCH_ENGINE_MANAGER_HANDLER_H_
6 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_SEARCH_ENGINE_MANAGER_HANDLER_H_ 6 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_SEARCH_ENGINE_MANAGER_HANDLER_H_
7 7
8 #include <memory>
9
8 #include "base/macros.h" 10 #include "base/macros.h"
9 #include "chrome/browser/ui/search_engines/edit_search_engine_controller.h" 11 #include "chrome/browser/ui/search_engines/edit_search_engine_controller.h"
10 #include "chrome/browser/ui/webui/options/options_ui.h" 12 #include "chrome/browser/ui/webui/options/options_ui.h"
11 #include "ui/base/models/table_model_observer.h" 13 #include "ui/base/models/table_model_observer.h"
12 14
13 class KeywordEditorController; 15 class KeywordEditorController;
14 16
15 namespace extensions { 17 namespace extensions {
16 class Extension; 18 class Extension;
17 } 19 }
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 67
66 // Called when an edit is cancelled. 68 // Called when an edit is cancelled.
67 // Called from WebUI. 69 // Called from WebUI.
68 void EditCancelled(const base::ListValue* args); 70 void EditCancelled(const base::ListValue* args);
69 71
70 // Called when an edit is finished and should be saved. 72 // Called when an edit is finished and should be saved.
71 // Called from WebUI. 73 // Called from WebUI.
72 void EditCompleted(const base::ListValue* args); 74 void EditCompleted(const base::ListValue* args);
73 75
74 // Returns a dictionary to pass to WebUI representing the given search engine. 76 // Returns a dictionary to pass to WebUI representing the given search engine.
75 base::DictionaryValue* CreateDictionaryForEngine(int index, bool is_default); 77 std::unique_ptr<base::DictionaryValue> CreateDictionaryForEngine(
78 int index,
79 bool is_default);
76 80
77 // Returns a dictionary to pass to WebUI representing the extension. 81 // Returns a dictionary to pass to WebUI representing the extension.
78 base::DictionaryValue* CreateDictionaryForExtension( 82 base::DictionaryValue* CreateDictionaryForExtension(
79 const extensions::Extension& extension); 83 const extensions::Extension& extension);
80 84
81 DISALLOW_COPY_AND_ASSIGN(SearchEngineManagerHandler); 85 DISALLOW_COPY_AND_ASSIGN(SearchEngineManagerHandler);
82 }; 86 };
83 87
84 } // namespace options 88 } // namespace options
85 89
86 #endif // CHROME_BROWSER_UI_WEBUI_OPTIONS_SEARCH_ENGINE_MANAGER_HANDLER_H_ 90 #endif // CHROME_BROWSER_UI_WEBUI_OPTIONS_SEARCH_ENGINE_MANAGER_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698