chrome/browser/ui/webui/settings/search_engines_handler.h - Issue 2086763002: Don't use deprecated ListValue::Append(Value*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/search_engines_handler.h

Issue 2086763002: Don't use deprecated ListValue::Append(Value*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/quota_internals/quota_internals_types.cc ('k') | chrome/browser/ui/webui/settings/search_engines_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/search_engines_handler.h

diff --git a/chrome/browser/ui/webui/settings/search_engines_handler.h b/chrome/browser/ui/webui/settings/search_engines_handler.h

index 650ac84d4b74e80040c4f29845a9788d8e54c91a..b143428432b83d88a353a504120ae1a2bb9e6ab8 100644

--- a/chrome/browser/ui/webui/settings/search_engines_handler.h

+++ b/chrome/browser/ui/webui/settings/search_engines_handler.h

@@ -83,7 +83,9 @@ class SearchEnginesHandler : public SettingsPageUIHandler,

void HandleDisableExtension(const base::ListValue* args);

// Returns a dictionary to pass to WebUI representing the given search engine.

- base::DictionaryValue* CreateDictionaryForEngine(int index, bool is_default);

+ std::unique_ptr<base::DictionaryValue> CreateDictionaryForEngine(

+ int index,

+ bool is_default);

// Returns a dictionary to pass to WebUI representing the extension.

base::DictionaryValue* CreateDictionaryForExtension(