net/log/trace_net_log_observer_unittest.cc - Issue 2086763002: Don't use deprecated ListValue::Append(Value*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/log/trace_net_log_observer_unittest.cc

Issue 2086763002: Don't use deprecated ListValue::Append(Value*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/log/trace_net_log_observer_unittest.cc

diff --git a/net/log/trace_net_log_observer_unittest.cc b/net/log/trace_net_log_observer_unittest.cc

index 5c63f41f7690ac77cc0f64190b6af728fe847923..1844067a38b1f9ff82b0a726d4ecd090d0135dbd 100644

--- a/net/log/trace_net_log_observer_unittest.cc

+++ b/net/log/trace_net_log_observer_unittest.cc

@@ -127,7 +127,7 @@ class TraceNetLogObserverTest : public testing::Test {

}

if (category != kNetLogTracingCategory)

continue;

- filtered_trace_events->Append(dict->DeepCopy());

+ filtered_trace_events->Append(dict->CreateDeepCopy());

}

return filtered_trace_events;

}

« no previous file with comments | « net/log/net_log_unittest.cc ('k') | no next file » | no next file with comments »