Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3835)

Unified Diff: chrome/browser/ui/webui/options/search_engine_manager_handler.h

Issue 2086763002: Don't use deprecated ListValue::Append(Value*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/search_engine_manager_handler.h
diff --git a/chrome/browser/ui/webui/options/search_engine_manager_handler.h b/chrome/browser/ui/webui/options/search_engine_manager_handler.h
index 7ffb99282e646b59fae6ec9b8eb69f4530f92837..9de72bfac3c3bd04da9baa968163410e599143e7 100644
--- a/chrome/browser/ui/webui/options/search_engine_manager_handler.h
+++ b/chrome/browser/ui/webui/options/search_engine_manager_handler.h
@@ -5,6 +5,8 @@
#ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_SEARCH_ENGINE_MANAGER_HANDLER_H_
#define CHROME_BROWSER_UI_WEBUI_OPTIONS_SEARCH_ENGINE_MANAGER_HANDLER_H_
+#include <memory>
+
#include "base/macros.h"
#include "chrome/browser/ui/search_engines/edit_search_engine_controller.h"
#include "chrome/browser/ui/webui/options/options_ui.h"
@@ -72,7 +74,9 @@ class SearchEngineManagerHandler : public OptionsPageUIHandler,
void EditCompleted(const base::ListValue* args);
// Returns a dictionary to pass to WebUI representing the given search engine.
- base::DictionaryValue* CreateDictionaryForEngine(int index, bool is_default);
+ std::unique_ptr<base::DictionaryValue> CreateDictionaryForEngine(
+ int index,
+ bool is_default);
// Returns a dictionary to pass to WebUI representing the extension.
base::DictionaryValue* CreateDictionaryForExtension(

Powered by Google App Engine
This is Rietveld 408576698