Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: chrome/browser/ui/webui/quota_internals/quota_internals_types.h

Issue 2086763002: Don't use deprecated ListValue::Append(Value*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/quota_internals/quota_internals_types.h
diff --git a/chrome/browser/ui/webui/quota_internals/quota_internals_types.h b/chrome/browser/ui/webui/quota_internals/quota_internals_types.h
index 53ea9dd7eb69074be419a32a6ca38630e34a2663..94a877e5d7915c1ddbf12eae9b457ff5565807e0 100644
--- a/chrome/browser/ui/webui/quota_internals/quota_internals_types.h
+++ b/chrome/browser/ui/webui/quota_internals/quota_internals_types.h
@@ -8,6 +8,7 @@
#include <stdint.h>
#include <map>
+#include <memory>
#include <string>
#include "base/time/time.h"
@@ -34,9 +35,9 @@ class GlobalStorageInfo {
void set_quota(int64_t quota) { quota_ = quota; }
- // Create new Value for passing to WebUI page. Caller is responsible for
- // deleting the returned pointer.
- base::Value* NewValue() const;
+ // Create new Value for passing to WebUI page.
+ std::unique_ptr<base::Value> NewValue() const;
+
private:
storage::StorageType type_;
@@ -55,9 +56,9 @@ class PerHostStorageInfo {
void set_quota(int64_t quota) { quota_ = quota; }
- // Create new Value for passing to WebUI page. Caller is responsible for
- // deleting the returned pointer.
- base::Value* NewValue() const;
+ // Create new Value for passing to WebUI page.
+ std::unique_ptr<base::Value> NewValue() const;
+
private:
std::string host_;
storage::StorageType type_;
@@ -89,9 +90,9 @@ class PerOriginStorageInfo {
last_modified_time_ = last_modified_time;
}
- // Create new Value for passing to WebUI page. Caller is responsible for
- // deleting the returned pointer.
- base::Value* NewValue() const;
+ // Create new Value for passing to WebUI page.
+ std::unique_ptr<base::Value> NewValue() const;
+
private:
GURL origin_;
storage::StorageType type_;

Powered by Google App Engine
This is Rietveld 408576698