Don't use deprecated ListValue::Append(Value*) overload.

chrome/browser/ui/webui/identity_internals_ui.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/identity_internals_ui.h"
 
+#include <memory>
 #include <set>
 #include <string>
+#include <utility>

[Dan Beam, 2016/06/21 00:54:12]

what's this for?  i don't see a std::move() in this file

[dcheng, 2016/06/21 18:56:01]

No clue. I'm guessing I needed it in an earlier iteration of the mega patch and
found a different way to rewrite the code that doesn't need it?

In any case, removed.

 
 #include "base/bind.h"
 #include "base/i18n/time_formatting.h"
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/api/identity/identity_api.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/generated_resources.h"
@@ skipping 52 matching lines @@
   const base::string16 GetStatus(
       const extensions::IdentityTokenCacheValue& token_cache_value);
 
   // Gets a string representation of an expiration time of the access token in
   // |token_cache_value|.
   const std::string GetExpirationTime(
       const extensions::IdentityTokenCacheValue& token_cache_value);
 
   // Converts a pair of |token_cache_key| and |token_cache_value| to a
   // DictionaryValue object with corresponding information in a localized and
-  // readable form and returns a pointer to created object. Caller gets the
-  // ownership of the returned object.
-  base::DictionaryValue* GetInfoForToken(
+  // readable form and returns a pointer to created object.
+  std::unique_ptr<base::DictionaryValue> GetInfoForToken(
       const extensions::ExtensionTokenKey& token_cache_key,
       const extensions::IdentityTokenCacheValue& token_cache_value);
 
   // Gets all of the tokens stored in IdentityAPI token cache and returns them
   // to the caller using Javascript callback function
   // |identity_internals.returnTokens()|.
   void GetInfoForAllTokens(const base::ListValue* args);
 
   // Initiates revoking of the token, based on the extension ID and token
   // passed as entries in the |args| list. Updates the caller of completion
@@ skipping 108 matching lines @@
   NOTREACHED();
   return base::string16();
 }
 
 const std::string IdentityInternalsUIMessageHandler::GetExpirationTime(
     const extensions::IdentityTokenCacheValue& token_cache_value) {
   return base::UTF16ToUTF8(base::TimeFormatFriendlyDateAndTime(
       token_cache_value.expiration_time()));
 }
 
-base::DictionaryValue* IdentityInternalsUIMessageHandler::GetInfoForToken(
+std::unique_ptr<base::DictionaryValue>
+IdentityInternalsUIMessageHandler::GetInfoForToken(
     const extensions::ExtensionTokenKey& token_cache_key,
     const extensions::IdentityTokenCacheValue& token_cache_value) {
-  base::DictionaryValue* token_data = new base::DictionaryValue();
+  std::unique_ptr<base::DictionaryValue> token_data(
+      new base::DictionaryValue());
   token_data->SetString(kExtensionId, token_cache_key.extension_id);
   token_data->SetString(kExtensionName, GetExtensionName(token_cache_key));
   token_data->Set(kScopes, GetScopes(token_cache_key));
   token_data->SetString(kStatus, GetStatus(token_cache_value));
   token_data->SetString(kAccessToken, token_cache_value.token());
   token_data->SetString(kTokenExpirationTime,
                         GetExpirationTime(token_cache_value));
   return token_data;
 }
 
@@ skipping 88 matching lines @@
   html_source->AddResourcePath("identity_internals.js",
       IDR_IDENTITY_INTERNALS_JS);
   html_source->SetDefaultResource(IDR_IDENTITY_INTERNALS_HTML);
 
   content::WebUIDataSource::Add(Profile::FromWebUI(web_ui), html_source);
 
   web_ui->AddMessageHandler(new IdentityInternalsUIMessageHandler());
 }
 
 IdentityInternalsUI::~IdentityInternalsUI() {}