make the filter mode for GrTextureAccess an enum so we can plumb down

make the filter mode for GrTextureAccess an enum so we can plumb down 
the paint's filter modes to the GPU

BUG=
R=bsalomon@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10368

[bsalomon, 2013-07-25 17:41:48]

https://codereview.chromium.org/20362002/diff/1/src/core/SkBitmapProcShader.cpp
File src/core/SkBitmapProcShader.cpp (right):

https://codereview.chromium.org/20362002/diff/1/src/core/SkBitmapProcShader.c...
src/core/SkBitmapProcShader.cpp:371: "Sorry, I don't yet support high quality "
can we log the error but just continue using mips?

https://codereview.chromium.org/20362002/diff/1/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/20362002/diff/1/src/gpu/GrContext.cpp#newcode336
src/gpu/GrContext.cpp:336: GrTextureParams params(SkShader::kClamp_TileMode,
filterMode);
Actually I think we just want to set knone or kbilerp here..

Unextended ES2 doesn't allow NPOT textures to be used with mip filtering or wrap
modes other than clamp.

This function will stretch the base level of a NPOT texture to the next POT so
that it can be used with wrap modes or mipmaps.

We do a non-bilerp stretch when the caller asked for an unfiltered draw. This
means that the stretched texture only has pixel values that were present in the
original bitmap. Whether the stretch was bilerped or not is recorded in the key
for the stretched texture so that we one when the caller asks for no filtering
and the other with filtering. I think the filtered stretched version could be
used for both the mip and bilerp cases.

Maybe we should go back to having a bool for NeedsFiltering() and just rename it
to NeedsFilteringOrMips().

This whole thing is of decreasing relevance as all the newer GPUs support the
extension that removes the limitations on NPOT.

[humper, 2013-07-25 18:18:13]

https://codereview.chromium.org/20362002/diff/1/src/core/SkBitmapProcShader.cpp
File src/core/SkBitmapProcShader.cpp (right):

https://codereview.chromium.org/20362002/diff/1/src/core/SkBitmapProcShader.c...
src/core/SkBitmapProcShader.cpp:371: "Sorry, I don't yet support high quality "
On 2013/07/25 17:41:48, bsalomon wrote:
> can we log the error but just continue using mips?

sure.  Done.

[bsalomon, 2013-07-25 18:25:25]

On 2013/07/25 18:18:13, humper wrote:
>
https://codereview.chromium.org/20362002/diff/1/src/core/SkBitmapProcShader.cpp
> File src/core/SkBitmapProcShader.cpp (right):
> 
>
https://codereview.chromium.org/20362002/diff/1/src/core/SkBitmapProcShader.c...
> src/core/SkBitmapProcShader.cpp:371: "Sorry, I don't yet support high quality
"
> On 2013/07/25 17:41:48, bsalomon wrote:
> > can we log the error but just continue using mips?
> 
> sure.  Done.

lgtm

[humper, 2013-07-25 18:49:18]

Committed patchset #3 manually as r10368 (presubmit successful).

[fmalita_google_do_not_use, 2013-07-25 19:54:41]

On 2013/07/25 18:49:18, humper wrote:
> Committed patchset #3 manually as r10368 (presubmit successful).

Is this expected to break a boatload of GPU GMs? PTAL.

['python', 'gm/display_json_results.py',
'/home/chrome-bot/skia-buildbot/skiabot-shuttle-ubuntu12-nexus7-003/buildbot/third_party/chromium_buildbot/slave/Test-Android-Nexus7-Tegra3-Arm7-Debug/gm/actual/base-android-nexus-7/actual-results.json']
[12:32:52.911949] [ ] 0 IgnoredExpectationsMismatch: 
[12:32:52.912148] [*] 105 ExpectationsMismatch: xfermodeimagefilter_gpu.png
blurrect_5_100_2_normal_fast_gpu.png pathfill_gpu.png strokerect_gpu.png
texdata_gpu.png giantbitmap_mirror_bilerp_rotate_gpu.png morphology_gpu.png
poly2poly_gpu.png strokes_poly_gpu.png ninepatch-stretch_gpu.png
giantbitmap_mirror_bilerp_scale_gpu.png giantbitmap_repeat_bilerp_rotate_gpu.png
blurrect_25_100_20_outer_fast_gpu.png bigmatrix_gpu.png
giantbitmap_clamp_bilerp_scale_gpu.png stroke-fill_gpu.png
simpleaaclip_path_gpu.png giantbitmap_clamp_point_scale_gpu.png
mixed_xfermodes_gpu.png patheffect_gpu.png gradients_degenerate_2pt_gpu.png
arithmode_gpu.png drawbitmapmatrix_gpu.png blurrect_5_100_2_outer_slow_gpu.png
clamped_gradients_gpu.png lighting_gpu.png
giantbitmap_repeat_point_scale_gpu.png giantbitmap_repeat_bilerp_scale_gpu.png
complexclip_aa_gpu.png giantbitmap_clamp_point_rotate_gpu.png
blurrect_25_100_2_normal_fast_gpu.png texteffects_gpu.png
shaderbounds_linear_gpu.png twopointconical_gpu.png imagefiltersbase_gpu.png
dashcubics_gpu.png complexclip2_rect_aa_gpu.png
gradients_local_perspective_gpu.png hairmodes_gpu.png aaclip_gpu.png
giantbitmap_mirror_point_rotate_gpu.png gradients_view_perspective_gpu.png
blurrect_5_5_2_inner_fast_gpu.png complexclip2_path_aa_gpu.png
blurrect_5_5_2_inner_slow_gpu.png lcdtext_gpu.png
blurrect_5_5_2_outer_slow_gpu.png testimagefilters_gpu.png
blurrect_25_100_2_inner_fast_gpu.png displacement_gpu.png roundrects_gpu.png
filltypespersp_gpu.png blurrect_25_100_2_outer_fast_gpu.png
blurrect_25_100_20_outer_slow_gpu.png imageblur_gpu.png
complexclip_bw_layer_gpu.png tablecolorfilter_gpu.png
blurrect_5_100_2_outer_fast_gpu.png giantbitmap_clamp_bilerp_rotate_gpu.png
path-reverse_gpu.png strokes3_gpu.png perlinnoise_gpu.png xfermodes2_gpu.png
drawlooper_gpu.png blurrect_25_100_2_outer_slow_gpu.png dashing3_gpu.png
shadows_gpu.png blurrect_5_100_20_outer_slow_gpu.png
blurrect_5_5_2_normal_slow_gpu.png bitmapfilters_gpu.png
simpleaaclip_rect_gpu.png radial_gradient_gpu.png tilemodes_gpu.png
blurrect_25_100_2_normal_slow_gpu.png blurrect_5_100_20_outer_fast_gpu.png
gradients_gpu.png blurrect_5_100_2_normal_slow_gpu.png nocolorbleed_gpu.png
giantbitmap_mirror_point_scale_gpu.png ovals_gpu.png aarectmodes_gpu.png
complexclip_aa_layer_gpu.png blurrect_25_100_2_inner_slow_gpu.png
bitmapscroll_gpu.png blurs_gpu.png complexclip_bw_gpu.png emptypath_gpu.png
matrixconvolution_gpu.png imagefiltersgraph_gpu.png dashing2_gpu.png
verttext2_gpu.png blurrect_5_100_2_inner_slow_gpu.png
blurrect_5_5_2_normal_fast_gpu.png xfermodes_gpu.png
colorfilterimagefilter_gpu.png blurrect_5_100_2_inner_fast_gpu.png
circles_gpu.png gradtext_gpu.png strokes_round_gpu.png filltypes_gpu.png
rects_gpu.png pathinvfill_gpu.png giantbitmap_repeat_point_rotate_gpu.png
blurrect_5_5_2_outer_fast_gpu.png rrect_clip_aa_gpu.png 
[12:32:52.912297] [ ] 252 MissingExpectations
[12:32:52.912383] [ ] 321 Passed
[12:32:52.912466] (results marked with [*] will cause nonzero return value)


http://108.170.217.252:10115/builders/Test-Android-Nexus7-Tegra3-Arm7-Debug?r...

[fmalita_google_do_not_use, 2013-07-25 20:07:34]

Mike pointed out a unit test is also failing (seems to be related to this CL
also):

http://108.170.217.252:10115/builders/Test-Android-Nexus7-Tegra3-Arm7-Debug/b...