Use SourceLocation when reporting runtime exceptions.

Use SourceLocation when reporting runtime exceptions.

This migrates all plumbing to use SourceLocation and puts
all the logic for gathering location information into SourceLocation.

Next logical step would be to use SourceLocation in ErrorEvent internally,
which should add stack traces in some places (e.g. when we postpone
dispatching error event) and remove more plumbing.

BUG=613882
Committed: https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed
Cr-Commit-Position: refs/heads/master@{#396122}

[dgozman, 2016-05-24 18:50:36]

dgozman@chromium.org changed reviewers:
+ haraken@chromium.org, jochen@chromium.org, pfeldman@chromium.org

[dgozman, 2016-05-24 18:50:37]

Could you please take a look?

https://codereview.chromium.org/2010603002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
(right):

https://codereview.chromium.org/2010603002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp:174: if
(m_workerObject->dispatchEvent(event) == DispatchEventResult::NotCanceled)
Here is a semantic change: we no longer post back to worker thread if exception
was handled on main thread. I don't see any observable side-effects, so this
should be fine.

[haraken, 2016-05-24 19:48:34]

bindings/ LGTM

https://codereview.chromium.org/2010603002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp (right):

https://codereview.chromium.org/2010603002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp:86: unsigned
columnNumber =
message->GetStartColumn(isolate->GetCurrentContext()).FromMaybe(-1) + 1;

Use v8Call macros in V8BindingMacros.h.

https://codereview.chromium.org/2010603002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp:95:
V8StringResource<> v8ResourceName(resourceName);

url = toCoreString(resourceName);

will work.

[pfeldman, 2016-05-24 23:06:04]

lgtm

[dgozman, 2016-05-24 23:13:22]

https://codereview.chromium.org/2010603002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp (right):

https://codereview.chromium.org/2010603002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp:86: unsigned
columnNumber =
message->GetStartColumn(isolate->GetCurrentContext()).FromMaybe(-1) + 1;
On 2016/05/24 19:48:34, haraken wrote:
> 
> Use v8Call macros in V8BindingMacros.h.

Done.

https://codereview.chromium.org/2010603002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp:95:
V8StringResource<> v8ResourceName(resourceName);
On 2016/05/24 19:48:34, haraken wrote:
> 
> url = toCoreString(resourceName);
> 
> will work.

Done. Used toCoreStringWithUndefinedOrNullCheck, since it's v8::Value.

[dgozman, 2016-05-25 20:22:24]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-05-25 20:22:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2010603002/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2016-05-25 20:23:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2010603002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2010603002/40001

[commit-bot: I haz the power, 2016-05-25 20:48:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 20:48:24]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-05-25 21:25:02]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-25 21:25:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2010603002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2010603002/60001

[commit-bot: I haz the power, 2016-05-26 00:50:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 00:50:06]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dgozman, 2016-05-26 03:07:53]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-05-26 03:07:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2010603002/#ps60001
(title: "test fixes")

[commit-bot: I haz the power, 2016-05-26 03:08:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2010603002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2010603002/60001

[commit-bot: I haz the power, 2016-05-26 05:06:57]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-26 05:07:59]

Description was changed from

==========
Use SourceLocation when reporting runtime exceptions.

This migrates all plumbing to use SourceLocation and puts
all the logic for gathering location information into SourceLocation.

Next logical step would be to use SourceLocation in ErrorEvent internally,
which should add stack traces in some places (e.g. when we postpone
dispatching error event) and remove more plumbing.

BUG=613882
==========

to

==========
Use SourceLocation when reporting runtime exceptions.

This migrates all plumbing to use SourceLocation and puts
all the logic for gathering location information into SourceLocation.

Next logical step would be to use SourceLocation in ErrorEvent internally,
which should add stack traces in some places (e.g. when we postpone
dispatching error event) and remove more plumbing.

BUG=613882

Committed: https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed
Cr-Commit-Position: refs/heads/master@{#396122}
==========

[commit-bot: I haz the power, 2016-05-26 05:08:01]

Patchset 4 (id:??) landed as
https://crrev.com/dcf3826071f4aa88abe1bd2ebe3a71f510a238ed
Cr-Commit-Position: refs/heads/master@{#396122}