third_party/WebKit/Source/core/testing/NullExecutionContext.h - Issue 2010603002: Use SourceLocation when reporting runtime exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/NullExecutionContext.h

Issue 2010603002: Use SourceLocation when reporting runtime exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2004243002

Patch Set: test fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp ('k') | third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/testing/NullExecutionContext.h

diff --git a/third_party/WebKit/Source/core/testing/NullExecutionContext.h b/third_party/WebKit/Source/core/testing/NullExecutionContext.h

index 3435f05d9d0679057fae45f7e05853a0160a234b..10a4500f9ff3bab56ef28d3adce45a70d80e753c 100644

--- a/third_party/WebKit/Source/core/testing/NullExecutionContext.h

+++ b/third_party/WebKit/Source/core/testing/NullExecutionContext.h

@@ -5,7 +5,7 @@

#ifndef NullExecutionContext_h

#define NullExecutionContext_h

-#include "bindings/core/v8/ScriptCallStack.h"

+#include "bindings/core/v8/SourceLocation.h"

#include "core/dom/ExecutionContext.h"

#include "core/dom/SecurityContext.h"

#include "core/events/EventQueue.h"

@@ -37,7 +37,7 @@ public:

DOMTimerCoordinator* timers() override { return nullptr; }

void addConsoleMessage(ConsoleMessage*) override { }

- void logExceptionToConsole(const String& errorMessage, int scriptId, const String& sourceURL, int lineNumber, int columnNumber, PassRefPtr<ScriptCallStack>) override { }

+ void logExceptionToConsole(const String& errorMessage, PassOwnPtr<SourceLocation>) override { }

void setIsSecureContext(bool);

bool isSecureContext(String& errorMessage, const SecureContextCheck = StandardSecureContextCheck) const override;