third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp - Issue 2010603002: Use SourceLocation when reporting runtime exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp

Issue 2010603002: Use SourceLocation when reporting runtime exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2004243002

Patch Set: test fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.h ('k') | third_party/WebKit/Source/bindings/core/v8/SourceLocation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp

index 6b954e3af0b1995f7b56c99f86c9998953cd36e6..b7c5b0899459757827109de34e9e1ef43421e499 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp

@@ -40,15 +40,6 @@

namespace blink {

-PassRefPtr<ScriptCallStack> ScriptCallStack::create(v8::Isolate* isolate, v8::Local<v8::StackTrace> stackTrace, size_t maxStackSize)

- V8PerIsolateData* data = V8PerIsolateData::from(isolate);

- if (!data->threadDebugger())

- return nullptr;

- std::unique_ptr<V8StackTrace> stack = data->threadDebugger()->debugger()->createStackTrace(stackTrace, maxStackSize);

- return stack ? adoptRef(new ScriptCallStack(std::move(stack))) : nullptr;

PassRefPtr<ScriptCallStack> ScriptCallStack::capture(size_t maxStackSize)

{

v8::Isolate* isolate = v8::Isolate::GetCurrent();