Use SourceLocation when reporting runtime exceptions.

third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "bindings/core/v8/SourceLocation.h"
 
 #include "bindings/core/v8/V8PerIsolateData.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExecutionContext.h"
 #include "core/dom/ScriptableDocumentParser.h"
@@ skipping 48 matching lines @@
             if (document->scriptableDocumentParser()->isParsingAtLineNumber())
                 lineNumber = document->scriptableDocumentParser()->lineNumber().oneBasedInt();
         }
         return SourceLocation::create(document->url().getString(), lineNumber, 0, std::move(stackTrace));
     }
 
     return SourceLocation::create(executionContext ? executionContext->url().getString() : "", 0, 0, std::move(stackTrace));
 }
 
 // static
+PassOwnPtr<SourceLocation> SourceLocation::fromMessage(v8::Isolate* isolate, v8::Local<v8::Message> message, ExecutionContext* executionContext)
+{
+    v8::Local<v8::StackTrace> stack = message->GetStackTrace();
+
+    OwnPtr<V8StackTrace> stackTrace = nullptr;
+    V8PerIsolateData* data = V8PerIsolateData::from(isolate);
+    if (data && data->threadDebugger())
+        stackTrace = data->threadDebugger()->debugger()->createStackTrace(stack);
+
+    int scriptId = message->GetScriptOrigin().ScriptID()->Value();
+    if (!stack.IsEmpty() && stack->GetFrameCount() > 0) {
+        int topScriptId = stack->GetFrame(0)->GetScriptId();
+        if (topScriptId == scriptId)
+            scriptId = 0;
+    }
+
+    unsigned lineNumber = message->GetLineNumber(isolate->GetCurrentContext()).FromMaybe(0);
+    unsigned columnNumber = message->GetStartColumn(isolate->GetCurrentContext()).FromMaybe(-1) + 1;

[haraken, 2016/05/24 19:48:34]

Use v8Call macros in V8BindingMacros.h.

[dgozman, 2016/05/24 23:13:22]

Done.

+
+    if ((!scriptId || !lineNumber) && stackTrace && !stackTrace->isEmpty())
+        return adoptPtr(new SourceLocation(stackTrace->topSourceURL(), stackTrace->topLineNumber(), stackTrace->topColumnNumber(), std::move(stackTrace), 0));
+
+    v8::Local<v8::Value> resourceName = message->GetScriptOrigin().ResourceName();
+    String url = executionContext->url();
+    bool shouldUseDocumentURL = executionContext->isDocument() && (resourceName.IsEmpty() || !resourceName->IsString());
+    if (!shouldUseDocumentURL) {
+        V8StringResource<> v8ResourceName(resourceName);

[haraken, 2016/05/24 19:48:34]

url = toCoreString(resourceName);

will work.

[dgozman, 2016/05/24 23:13:22]

Done. Used toCoreStringWithUndefinedOrNullCheck, since it's v8::Value.

+        if (v8ResourceName.prepare())
+            url = v8ResourceName;
+    }
+    return adoptPtr(new SourceLocation(url, lineNumber, columnNumber, std::move(stackTrace), scriptId));
+}
+
+// static
 PassOwnPtr<SourceLocation> SourceLocation::create(const String& url, unsigned lineNumber, unsigned columnNumber, PassOwnPtr<V8StackTrace> stackTrace, int scriptId)
 {
     return adoptPtr(new SourceLocation(url, lineNumber, columnNumber, std::move(stackTrace), scriptId));
 }
 
 SourceLocation::SourceLocation(const String& url, unsigned lineNumber, unsigned columnNumber, PassOwnPtr<V8StackTrace> stackTrace, int scriptId)
     : m_url(url)
     , m_lineNumber(lineNumber)
     , m_columnNumber(columnNumber)
     , m_stackTrace(std::move(stackTrace))
@@ skipping 19 matching lines @@
     value->endDictionary();
     value->endArray();
 }
 
 PassOwnPtr<SourceLocation> SourceLocation::clone() const
 {
     return adoptPtr(new SourceLocation(m_url, m_lineNumber, m_columnNumber, m_stackTrace ? m_stackTrace->clone() : nullptr, m_scriptId));
 }
 
 } // namespace blink