Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h

Issue 2010603002: Use SourceLocation when reporting runtime exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2004243002
Patch Set: test fixes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
diff --git a/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h b/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
index d223537f4a85c6e5cd4cb0a59bda626a72ad5edd..b64dc4719c206d6cdf1dbe6996bae88604f24551 100644
--- a/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
+++ b/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "bindings/core/v8/ScriptCallStack.h"
+#include "bindings/core/v8/SourceLocation.h"
#include "bindings/core/v8/V8CacheOptions.h"
#include "bindings/core/v8/V8GCController.h"
#include "core/frame/csp/ContentSecurityPolicy.h"
@@ -53,7 +53,11 @@ public:
MockWorkerReportingProxy() { }
~MockWorkerReportingProxy() override { }
- MOCK_METHOD5(reportException, void(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL, int exceptionId));
+ MOCK_METHOD2(reportExceptionMock, void(const String& errorMessage, SourceLocation*));
+ void reportException(const String& errorMessage, PassOwnPtr<SourceLocation> location)
+ {
+ reportExceptionMock(errorMessage, location.get());
+ }
MOCK_METHOD1(reportConsoleMessage, void(ConsoleMessage*));
MOCK_METHOD1(postMessageToPageInspector, void(const String&));
MOCK_METHOD0(postWorkerConsoleAgentEnabled, void());
@@ -148,7 +152,7 @@ public:
return EventTargetNames::DedicatedWorkerGlobalScope;
}
- void logExceptionToConsole(const String&, int, const String&, int, int, PassRefPtr<ScriptCallStack>) override
+ void logExceptionToConsole(const String&, PassOwnPtr<SourceLocation>) override
{
}

Powered by Google App Engine
This is Rietveld 408576698