third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h - Issue 2010603002: Use SourceLocation when reporting runtime exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

Issue 2010603002: Use SourceLocation when reporting runtime exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2004243002

Patch Set: test fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h ('k') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

index c87e4bce64a2f0c27ee47b21262eb196e9198008..60e56fa37b4e7e03a8c20f545045c811c6b553b9 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

@@ -83,7 +83,7 @@ public:

void dispatchSyncEvent(int, const WebString& tag, LastChanceOption) override;

// WorkerReportingProxy overrides:

- void reportException(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL, int exceptionId) override;

+ void reportException(const String& errorMessage, PassOwnPtr<SourceLocation>) override;

void reportConsoleMessage(ConsoleMessage*) override;

void postMessageToPageInspector(const String&) override;

void postWorkerConsoleAgentEnabled() override { }