third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp - Issue 2010603002: Use SourceLocation when reporting runtime exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

Issue 2010603002: Use SourceLocation when reporting runtime exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2004243002

Patch Set: test fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp b/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

index 19c775d92473f141fddd55525e3a47332fd240a2..9a7c82293fcc9540ed1216742c0c05dc7c024b2b 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

@@ -30,9 +30,9 @@

#include "bindings/core/v8/V8LazyEventListener.h"

-#include "bindings/core/v8/ScriptCallStack.h"

#include "bindings/core/v8/ScriptController.h"

#include "bindings/core/v8/ScriptSourceCode.h"

+#include "bindings/core/v8/SourceLocation.h"

#include "bindings/core/v8/V8Binding.h"

#include "bindings/core/v8/V8DOMWrapper.h"

#include "bindings/core/v8/V8Document.h"

@@ -221,7 +221,7 @@ void V8LazyEventListener::fireErrorEvent(v8::Local<v8::Context> v8Context, Execu

else if (message->IsSharedCrossOrigin())

accessControlStatus = SharableCrossOrigin;

- executionContext->reportException(event, 0, nullptr, accessControlStatus);

+ executionContext->reportException(event, SourceLocation::create(m_sourceURL, lineNumber, columnNumber, nullptr), accessControlStatus);

}

} // namespace blink