Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerGlobalScope.h

Issue 2010603002: Use SourceLocation when reporting runtime exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2004243002
Patch Set: test fixes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
diff --git a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
index 6dd5e432d3841c1560f7c3c4e291bce5e9ac5360..ff21f438df06db5f2210af770e2dc7c874b297e2 100644
--- a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
+++ b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
@@ -141,7 +141,7 @@ public:
void addConsoleMessage(ConsoleMessage*) final;
ConsoleMessageStorage* messageStorage();
- void exceptionHandled(int exceptionId, bool isHandled);
+ void exceptionUnhandled(const String& errorMessage, PassOwnPtr<SourceLocation>);
virtual void scriptLoaded(size_t scriptSize, size_t cachedMetadataSize) { }
@@ -156,7 +156,7 @@ protected:
WorkerGlobalScope(const KURL&, const String& userAgent, WorkerThread*, double timeOrigin, PassOwnPtr<SecurityOrigin::PrivilegeData>, WorkerClients*);
void applyContentSecurityPolicyFromVector(const Vector<CSPHeaderAndType>& headers);
- void logExceptionToConsole(const String& errorMessage, int scriptId, const String& sourceURL, int lineNumber, int columnNumber, PassRefPtr<ScriptCallStack>) override;
+ void logExceptionToConsole(const String& errorMessage, PassOwnPtr<SourceLocation>) override;
void addMessageToWorkerConsole(ConsoleMessage*);
void setV8CacheOptions(V8CacheOptions v8CacheOptions) { m_v8CacheOptions = v8CacheOptions; }
@@ -201,8 +201,6 @@ private:
Member<ConsoleMessageStorage> m_messageStorage;
- unsigned long m_workerExceptionUniqueIdentifier;
- HeapHashMap<unsigned long, Member<ConsoleMessage>> m_pendingMessages;
HeapListHashSet<Member<V8AbstractEventListener>> m_eventListeners;
};

Powered by Google App Engine
This is Rietveld 408576698