third_party/WebKit/Source/core/workers/WorkerReportingProxy.h - Issue 2010603002: Use SourceLocation when reporting runtime exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerReportingProxy.h

Issue 2010603002: Use SourceLocation when reporting runtime exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2004243002

Patch Set: test fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp ('k') | third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/WorkerReportingProxy.h

diff --git a/third_party/WebKit/Source/core/workers/WorkerReportingProxy.h b/third_party/WebKit/Source/core/workers/WorkerReportingProxy.h

index eba4ea3c83eadeabd4ab90c8a9566bc3e7090ac0..ea14f9233ef390a65e86aa706ad9e86c32849ae5 100644

--- a/third_party/WebKit/Source/core/workers/WorkerReportingProxy.h

+++ b/third_party/WebKit/Source/core/workers/WorkerReportingProxy.h

@@ -34,10 +34,12 @@

#include "core/CoreExport.h"

#include "platform/heap/Handle.h"

#include "wtf/Forward.h"

+#include "wtf/PassOwnPtr.h"

namespace blink {

class ConsoleMessage;

+class SourceLocation;

class WorkerGlobalScope;

// APIs used by workers to report console and worker activity.

@@ -45,7 +47,7 @@ class CORE_EXPORT WorkerReportingProxy {

public:

virtual ~WorkerReportingProxy() { }

- virtual void reportException(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL, int exceptionId) = 0;

+ virtual void reportException(const String& errorMessage, PassOwnPtr<SourceLocation>) = 0;

virtual void reportConsoleMessage(ConsoleMessage*) = 0;

virtual void postMessageToPageInspector(const String&) = 0;

virtual void postWorkerConsoleAgentEnabled() = 0;