Add base class for GLTestContext and add new subclass VkTestContext.

Add base class for GLTestContext and add new subclass VkTestContext.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1964243003

Committed: https://skia.googlesource.com/skia/+/18a2f9dff839a3f60850c25e1a701b682a497afb

[bsalomon, 2016-05-11 14:39:41]

Description was changed from

==========
Add base class for GLTestContext and add new subclass VkTestContext.

BUG=skia:
==========

to

==========
Add base class for GLTestContext and add new subclass VkTestContext.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-05-11 14:51:04]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com

[egdaniel, 2016-05-11 15:39:30]

lgtm with nits

https://codereview.chromium.org/1964243003/diff/20001/tools/gpu/TestContext.h
File tools/gpu/TestContext.h (right):

https://codereview.chromium.org/1964243003/diff/20001/tools/gpu/TestContext.h...
tools/gpu/TestContext.h:71: SkAutoTDelete <SkGpuFenceSync> fFenceSync;
This is an AutoTDelete but you require that it has already been deleted before
the dtor

https://codereview.chromium.org/1964243003/diff/40001/tools/gpu/TestContext.cpp
File tools/gpu/TestContext.cpp (right):

https://codereview.chromium.org/1964243003/diff/40001/tools/gpu/TestContext.c...
tools/gpu/TestContext.cpp:3: * Copyright 2013 Google Inc.
2016

https://codereview.chromium.org/1964243003/diff/40001/tools/gpu/TestContext.h
File tools/gpu/TestContext.h (right):

https://codereview.chromium.org/1964243003/diff/40001/tools/gpu/TestContext.h...
tools/gpu/TestContext.h:38: 
extra line

https://codereview.chromium.org/1964243003/diff/40001/tools/gpu/vk/VkTestCont...
File tools/gpu/vk/VkTestContext.cpp (right):

https://codereview.chromium.org/1964243003/diff/40001/tools/gpu/vk/VkTestCont...
tools/gpu/vk/VkTestContext.cpp:16: VkTestContextImpl() :
VkTestContext(sk_sp<const GrVkBackendContext>(GrVkBackendContext::Create())) {}
100 chars

[bsalomon, 2016-05-11 15:52:49]

Took care of all the nits, but can you look at the delta between patchset 4 and
3? I broke something in patchset 2 by making VkTestContext::vk() return a
VkInterface and fixed it in patchset 4.

https://codereview.chromium.org/1964243003/diff/20001/tools/gpu/TestContext.h
File tools/gpu/TestContext.h (right):

https://codereview.chromium.org/1964243003/diff/20001/tools/gpu/TestContext.h...
tools/gpu/TestContext.h:71: SkAutoTDelete <SkGpuFenceSync> fFenceSync;
On 2016/05/11 15:39:29, egdaniel wrote:
> This is an AutoTDelete but you require that it has already been deleted before
> the dtor 

Done.

https://codereview.chromium.org/1964243003/diff/40001/tools/gpu/TestContext.cpp
File tools/gpu/TestContext.cpp (right):

https://codereview.chromium.org/1964243003/diff/40001/tools/gpu/TestContext.c...
tools/gpu/TestContext.cpp:3: * Copyright 2013 Google Inc.
On 2016/05/11 15:39:29, egdaniel wrote:
> 2016

Done.

https://codereview.chromium.org/1964243003/diff/40001/tools/gpu/TestContext.h
File tools/gpu/TestContext.h (right):

https://codereview.chromium.org/1964243003/diff/40001/tools/gpu/TestContext.h...
tools/gpu/TestContext.h:38: 
On 2016/05/11 15:39:29, egdaniel wrote:
> extra line

Done.

https://codereview.chromium.org/1964243003/diff/40001/tools/gpu/vk/VkTestCont...
File tools/gpu/vk/VkTestContext.cpp (right):

https://codereview.chromium.org/1964243003/diff/40001/tools/gpu/vk/VkTestCont...
tools/gpu/vk/VkTestContext.cpp:16: VkTestContextImpl() :
VkTestContext(sk_sp<const GrVkBackendContext>(GrVkBackendContext::Create())) {}
On 2016/05/11 15:39:30, egdaniel wrote:
> 100 chars

Done.

[bsalomon, 2016-05-11 15:53:53]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-11 15:54:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964243003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964243003/80001

[commit-bot: I haz the power, 2016-05-11 15:56:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 15:56:35]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[bsalomon, 2016-05-11 16:02:59]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-11 16:03:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964243003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964243003/100001

[commit-bot: I haz the power, 2016-05-11 16:22:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 16:22:56]

Dry run: This issue passed the CQ dry run.

[egdaniel, 2016-05-11 17:08:05]

lgtm

[bsalomon, 2016-05-11 17:08:20]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-05-11 17:08:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964243003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964243003/100001

[commit-bot: I haz the power, 2016-05-11 17:09:22]

Description was changed from

==========
Add base class for GLTestContext and add new subclass VkTestContext.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add base class for GLTestContext and add new subclass VkTestContext.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/18a2f9dff839a3f60850c25e1a701b682a497afb
==========

[commit-bot: I haz the power, 2016-05-11 17:09:23]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/18a2f9dff839a3f60850c25e1a701b682a497afb