Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 1971613003: Make unit tests use generic testcontext rather than glcontext (Closed)

Created:
4 years, 7 months ago by bsalomon
Modified:
4 years, 7 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@vknano
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : run deferredimage test on vk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -21 lines) Patch
M tests/GrContextFactoryTest.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
M tests/ImageTest.cpp View 1 5 chunks +16 lines, -15 lines 0 comments Download
M tools/gpu/GrContextFactory.h View 2 chunks +14 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
bsalomon
4 years, 7 months ago (2016-05-11 16:08:11 UTC) #3
egdaniel
lgtm
4 years, 7 months ago (2016-05-11 17:11:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971613003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971613003/20001
4 years, 7 months ago (2016-05-11 17:13:14 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 17:38:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0fd3c818612376afd54bad66d519feb7505b5d52

Powered by Google App Engine
This is Rietveld 408576698