Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Issue 1966013002: Turn ContextInfos returned by GrContextFactory into structs. (Closed)

Created:
4 years, 7 months ago by bsalomon
Modified:
4 years, 7 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : whitespace #

Total comments: 2

Patch Set 3 : Make targets other than DM that use GrContextFactory compile #

Patch Set 4 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -156 lines) Patch
M bench/nanobench.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M dm/DM.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M dm/DMSrcSink.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ApplyGammaTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/BitmapCopyTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/BlurTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ClearTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/CopySurfaceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/EGLImageTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/FloatingPointTextureTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/GLProgramsTest.cpp View 3 2 chunks +4 lines, -4 lines 0 comments Download
M tests/GpuColorFilterTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GpuDrawPathTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/GpuLayerCacheTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/GrContextAbandonTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrContextFactoryTest.cpp View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M tests/GrDrawTargetTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrSurfaceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrTextureMipMapInvalidationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageFilterCacheTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/ImageFilterTest.cpp View 13 chunks +13 lines, -13 lines 0 comments Download
M tests/ImageIsOpaqueTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageNewShaderTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/ImageTest.cpp View 13 chunks +18 lines, -18 lines 0 comments Download
M tests/PremulAlphaRoundTripTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PrimitiveProcessorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ProxyTest.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M tests/ReadPixelsTest.cpp View 5 chunks +7 lines, -6 lines 0 comments Download
M tests/ReadWriteAlphaTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/RecordReplaceDrawTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/RectangleTextureTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/SRGBReadWritePixelsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SpecialImageTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/SpecialSurfaceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SurfaceTest.cpp View 19 chunks +20 lines, -20 lines 0 comments Download
M tests/TessellatingPathRendererTests.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/TestTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/TextBlobCacheTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/VkClearTests.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/VkUploadPixelsTests.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M tests/VkWrapTests.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/WritePixelsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/skbug5221.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/gpu/GrContextFactory.h View 1 1 chunk +10 lines, -3 lines 0 comments Download
M tools/kilobench/kilobench.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/skiaserve/Request.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (8 generated)
bsalomon
The only interesting part of this change is in GrContextFactory.h. The rest is just replacing ...
4 years, 7 months ago (2016-05-10 21:42:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966013002/20001
4 years, 7 months ago (2016-05-10 21:43:02 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 7 months ago (2016-05-10 21:43:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/8497)
4 years, 7 months ago (2016-05-10 21:45:54 UTC) #8
egdaniel
looks like you may have missed a tool or two the used the Context https://codereview.chromium.org/1966013002/diff/20001/dm/DMSrcSink.cpp ...
4 years, 7 months ago (2016-05-11 00:37:56 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966013002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966013002/40001
4 years, 7 months ago (2016-05-11 02:14:46 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-11 02:34:53 UTC) #13
bsalomon
https://codereview.chromium.org/1966013002/diff/20001/dm/DMSrcSink.cpp File dm/DMSrcSink.cpp (right): https://codereview.chromium.org/1966013002/diff/20001/dm/DMSrcSink.cpp#newcode1090 dm/DMSrcSink.cpp:1090: factory.getContextInfo(fContextType, fContextOptions).grContext()->caps()->maxTextureSize(); On 2016/05/11 00:37:55, egdaniel wrote: > Maybe ...
4 years, 7 months ago (2016-05-11 13:00:17 UTC) #14
egdaniel
lgtm
4 years, 7 months ago (2016-05-11 13:05:07 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966013002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966013002/60001
4 years, 7 months ago (2016-05-11 13:09:24 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 13:33:09 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/8b7451aaf6b1c71e9d343a4df107893db277b6aa

Powered by Google App Engine
This is Rietveld 408576698