DescriptionFactor out GamepadCommon base class from Gamepad and WebKitGamepad
WebKitGamepad is a legacy interface for Gamepad, and hence there's a lot of duplicated code.
This reduces the duplication by C++ inheritance from a base class.
(Also cleanup for consistency and brevity.)
There isn't much code duplication for WebKitGamepadList/GamepadList,
so no benefit for a base class there, but tweaks.
Notes:
* Use C++ inheritance only; IDL files are unchanged
(*implementation* is inherited, *interface* is not)
* Inherit from an abstract GamepadCommon class
(needed for ScriptWrappable::init in constructor, avoids duplicate members and virtual methods)
Followup to:
Added non-prefixed navigator.getGamepads() with updated API
https://codereview.chromium.org/183313003/
BUG=344556
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169194
Patch Set 1 #Patch Set 2 : Cleaned up #
Total comments: 8
Patch Set 3 : Add ABC FIXME #
Total comments: 7
Patch Set 4 : Base class #Patch Set 5 : Tweak #
Total comments: 10
Patch Set 6 : Revised #
Total comments: 18
Patch Set 7 : Ctors and dtors in impl #Patch Set 8 : Other ctor/dtor #Patch Set 9 : Remove excess header #
Messages
Total messages: 24 (0 generated)
|