Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Side by Side Diff: Source/modules/gamepad/WebKitGamepadList.h

Issue 195993007: Factor out GamepadCommon base class from Gamepad and WebKitGamepad (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Revised Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebKitGamepadList_h 5 #ifndef WebKitGamepadList_h
6 #define WebKitGamepadList_h 6 #define WebKitGamepadList_h
7 7
8 #include "bindings/v8/ScriptWrappable.h" 8 #include "bindings/v8/ScriptWrappable.h"
9 #include "heap/Handle.h" 9 #include "heap/Handle.h"
10 #include "modules/gamepad/Gamepad.h"
10 #include "modules/gamepad/WebKitGamepad.h" 11 #include "modules/gamepad/WebKitGamepad.h"
11 #include "public/platform/WebGamepads.h" 12 #include "public/platform/WebGamepads.h"
12 #include "wtf/PassRefPtr.h" 13 #include "wtf/PassRefPtr.h"
13 #include "wtf/RefCounted.h" 14 #include "wtf/RefCounted.h"
14 #include "wtf/Vector.h" 15 #include "wtf/Vector.h"
15 16
16 namespace WebCore { 17 namespace WebCore {
17 18
18 class WebKitGamepadList : public RefCountedWillBeGarbageCollectedFinalized<WebKi tGamepadList>, public ScriptWrappable { 19 class WebKitGamepadList FINAL : public RefCountedWillBeGarbageCollectedFinalized <WebKitGamepadList>, public ScriptWrappable {
19 public: 20 public:
20 static PassRefPtrWillBeRawPtr<WebKitGamepadList> create() { return adoptRefW illBeNoop(new WebKitGamepadList); } 21 static PassRefPtrWillBeRawPtr<WebKitGamepadList> create()
21 ~WebKitGamepadList(); 22 {
23 return adoptRefWillBeNoop(new WebKitGamepadList);
24 }
25 ~WebKitGamepadList() { }
zerny-chromium 2014/03/13 09:48:00 Nit: keep the impl in cpp file
22 26
23 void set(unsigned index, PassRefPtrWillBeRawPtr<WebKitGamepad>); 27 void set(unsigned index, PassRefPtrWillBeRawPtr<WebKitGamepad>);
24 WebKitGamepad* item(unsigned index); 28 WebKitGamepad* item(unsigned index);
25 unsigned length() const; 29 unsigned length() const { return blink::WebGamepads::itemsLengthCap; }
26 30
27 void trace(Visitor*); 31 void trace(Visitor*);
28 32
29 private: 33 private:
30 WebKitGamepadList() 34 WebKitGamepadList() { ScriptWrappable::init(this); }
31 {
32 ScriptWrappable::init(this);
33 }
34
35 RefPtrWillBeMember<WebKitGamepad> m_items[blink::WebGamepads::itemsLengthCap ]; 35 RefPtrWillBeMember<WebKitGamepad> m_items[blink::WebGamepads::itemsLengthCap ];
36 }; 36 };
37 37
38 } // namespace WebCore 38 } // namespace WebCore
39 39
40 #endif // WebKitGamepadList_h 40 #endif // WebKitGamepadList_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698