Factor out GamepadCommon base class from Gamepad and WebKitGamepad

Source/modules/gamepad/WebKitGamepadList.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WebKitGamepadList_h
 #define WebKitGamepadList_h
 
 #include "bindings/v8/ScriptWrappable.h"
-#include "heap/Handle.h"
+#include "modules/gamepad/GamepadList.h"
 #include "modules/gamepad/WebKitGamepad.h"
-#include "public/platform/WebGamepads.h"
 #include "wtf/PassRefPtr.h"
-#include "wtf/RefCounted.h"
-#include "wtf/Vector.h"
 
 namespace WebCore {
 
-class WebKitGamepadList : public RefCountedWillBeGarbageCollectedFinalized<WebKitGamepadList>, public ScriptWrappable {
+// Inherit from concrete GamepadList class (instead of factoring out an abstract
+// GamepadListCommon class) so GamepadList is simple (unfactored) and low-cruft.
+class WebKitGamepadList : public GamepadList {
 public:
     static PassRefPtrWillBeRawPtr<WebKitGamepadList> create() { return adoptRefWillBeNoop(new WebKitGamepadList); }
-    ~WebKitGamepadList();
 
     void set(unsigned index, PassRefPtrWillBeRawPtr<WebKitGamepad>);
     WebKitGamepad* item(unsigned index);
-    unsigned length() const;
-
-    void trace(Visitor*);

[haraken, 2014/03/13 07:08:50]

As I commented, please keep the trace() method and trace m_items.

[Nils Barth (inactive), 2014/03/13 07:36:14]

Got it.

 
 private:
     WebKitGamepadList()
     {
+        // FIXME: don't call ScriptWrappable::init twice
+        // Instead, factor out a base class GamepadListCommon
         ScriptWrappable::init(this);
     }
 
     RefPtrWillBeMember<WebKitGamepad> m_items[blink::WebGamepads::itemsLengthCap];
 };
 
 } // namespace WebCore
 
 #endif // WebKitGamepadList_h