Factor out GamepadCommon base class from Gamepad and WebKitGamepad

Source/modules/gamepad/GamepadList.h

 /*
  * Copyright (C) 2011, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 18 matching lines @@
 #include "bindings/v8/ScriptWrappable.h"
 #include "heap/Handle.h"
 #include "modules/gamepad/Gamepad.h"
 #include "public/platform/WebGamepads.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
 #include "wtf/Vector.h"
 
 namespace WebCore {
 
-class GamepadList : public RefCountedWillBeGarbageCollectedFinalized<GamepadList>, public ScriptWrappable {
+class GamepadList FINAL : public RefCountedWillBeGarbageCollectedFinalized<GamepadList>, public ScriptWrappable {
 public:
-    static PassRefPtrWillBeRawPtr<GamepadList> create() { return adoptRefWillBeNoop(new GamepadList); }
-    ~GamepadList();
+    static PassRefPtrWillBeRawPtr<GamepadList> create()
+    {
+        return adoptRefWillBeNoop(new GamepadList);
+    }
+    ~GamepadList() { }
 
     void set(unsigned index, PassRefPtrWillBeRawPtr<Gamepad>);
     Gamepad* item(unsigned index);
-    unsigned length() const;
+    unsigned length() const { return blink::WebGamepads::itemsLengthCap; }

[kouhei (in TOK), 2014/03/13 09:05:11]

Is this correct? always return capacity?

[Nils Barth (inactive), 2014/03/13 09:15:14]

Yup (it's always length 4 in fact).
This is just inlined from the .cpp:
https://codereview.chromium.org/195993007/diff/80001/Source/modules/gamepad/G...

 
     void trace(Visitor*);
 
 private:
-    GamepadList()
-    {
-        ScriptWrappable::init(this);
-    }
-
+    GamepadList() { ScriptWrappable::init(this); }
     RefPtrWillBeMember<Gamepad> m_items[blink::WebGamepads::itemsLengthCap];
 };
 
 } // namespace WebCore
 
 #endif // GamepadList_h