Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 1929493002: Remove unnecessary uses of GarbageCollectedFinalized<>. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, szager+layoutwatch_chromium.org, jsbell+idb_chromium.org, blink-reviews-platform-graphics_chromium.org, tzik, webcomponents-bugzilla_chromium.org, dshwang, eae+blinkwatch, fs, dcheng, scheib+watch_chromium.org, apavlov+blink_chromium.org, kinuko+worker_chromium.org, kinuko+watch, kouhei+svg_chromium.org, danakj+watch_chromium.org, rwlbuis, caseq+blink_chromium.org, krit, drott+blinkwatch_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, Justin Novosad, hongchan, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, gavinp+loader_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, blink-reviews, gyuyoung2, pdr+svgwatchlist_chromium.org, blink-worker-reviews_chromium.org, philipj_slow, blink-reviews-style_chromium.org, zoltan1, Peter Beverloo, jbroman, blink-reviews-layout_chromium.org, mlamouri+watch-blink_chromium.org, nhiroki, Raymond Toy, feature-media-reviews_chromium.org, pdr+graphicswatchlist_chromium.org, lushnikov+blink_chromium.org, darktears, loading-reviews+fetch_chromium.org, Nate Chapin, Stephen Chennney, tyoshino+watch_chromium.org, ajuma+watch-canvas_chromium.org, eric.carlson_apple.com, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, falken, pfeldman+blink_chromium.org, ortuno+watch_chromium.org, f(malita), groby+blinkspell_chromium.org, cmumford, mlamouri+watch-screen-orientation_chromium.org, horo+watch_chromium.org, sergeyv+blink_chromium.org, kinuko+fileapi, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary uses of GarbageCollectedFinalized<>. Classes which finalize nothing on their own should derive from GarbageCollected<> instead. (As identified by the warn-unneeded-finalizer=1 GC plugin option.) R=haraken BUG=585328 Committed: https://crrev.com/e10d108bc9cabf82607b909f35fc541c313e2366 Cr-Commit-Position: refs/heads/master@{#390070} Committed: https://crrev.com/187a2805642014aead68645a21dd3ac2c3c5cecb Cr-Commit-Position: refs/heads/master@{#390165}

Patch Set 1 #

Patch Set 2 : add two leftover classes needing same treatment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -136 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/MediaQueryResult.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/IdTargetObserverRegistry.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverEntry.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverEntry.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeIntersectionObserverData.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeIntersectionObserverData.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeListsNodeData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScopedWindowFocusAllowedIndicator.h View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunner.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunner.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/V0CustomElementCallbackQueue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/custom/V0CustomElementProcessingStack.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventPath.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/MemoryCache.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/ValidityState.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectedFrames.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorOverlayHost.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorOverlayHost.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/DragController.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/DragController.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/page/FocusController.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/PatternAttributes.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGMatrixTearOff.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGMatrixTearOff.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerClients.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/HitRegion.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchManager.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchManager.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/GlobalIndexedDB.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/NavigatorPresentation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationDispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBuffer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLStatement.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLStatement.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/LifecycleContextTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/Filter.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/Filter.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/AssociatedURLLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
sof
please take a look. With https://codereview.chromium.org/1922913004/ in scope, clear out the remaining avoidable uses of ...
4 years, 7 months ago (2016-04-27 12:20:24 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-04-27 12:32:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929493002/20001
4 years, 7 months ago (2016-04-27 13:21:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-27 14:45:24 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e10d108bc9cabf82607b909f35fc541c313e2366 Cr-Commit-Position: refs/heads/master@{#390070}
4 years, 7 months ago (2016-04-27 14:48:09 UTC) #11
Justin Donnelly
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1923993002/ by jdonnelly@chromium.org. ...
4 years, 7 months ago (2016-04-27 19:05:31 UTC) #12
sof
On 2016/04/27 19:05:31, Justin Donnelly wrote: > A revert of this CL (patchset #2 id:20001) ...
4 years, 7 months ago (2016-04-27 20:06:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929493002/20001
4 years, 7 months ago (2016-04-27 20:07:59 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-27 20:13:46 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:12:31 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/187a2805642014aead68645a21dd3ac2c3c5cecb
Cr-Commit-Position: refs/heads/master@{#390165}

Powered by Google App Engine
This is Rietveld 408576698