Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: third_party/WebKit/Source/core/editing/InputMethodController.h

Issue 1929493002: Remove unnecessary uses of GarbageCollectedFinalized<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add two leftover classes needing same treatment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 23 matching lines...) Expand all
34 #include "platform/heap/Handle.h" 34 #include "platform/heap/Handle.h"
35 #include "wtf/Vector.h" 35 #include "wtf/Vector.h"
36 36
37 namespace blink { 37 namespace blink {
38 38
39 class Editor; 39 class Editor;
40 class LocalFrame; 40 class LocalFrame;
41 class Range; 41 class Range;
42 class Text; 42 class Text;
43 43
44 class CORE_EXPORT InputMethodController final : public GarbageCollectedFinalized <InputMethodController> { 44 class CORE_EXPORT InputMethodController final : public GarbageCollected<InputMet hodController> {
45 WTF_MAKE_NONCOPYABLE(InputMethodController); 45 WTF_MAKE_NONCOPYABLE(InputMethodController);
46 public: 46 public:
47 enum ConfirmCompositionBehavior { 47 enum ConfirmCompositionBehavior {
48 DoNotKeepSelection, 48 DoNotKeepSelection,
49 KeepSelection, 49 KeepSelection,
50 }; 50 };
51 51
52 static InputMethodController* create(LocalFrame&); 52 static InputMethodController* create(LocalFrame&);
53 ~InputMethodController();
54 DECLARE_TRACE(); 53 DECLARE_TRACE();
55 54
56 // international text input composition 55 // international text input composition
57 bool hasComposition() const; 56 bool hasComposition() const;
58 void setComposition(const String&, const Vector<CompositionUnderline>&, unsi gned selectionStart, unsigned selectionEnd); 57 void setComposition(const String&, const Vector<CompositionUnderline>&, unsi gned selectionStart, unsigned selectionEnd);
59 void setCompositionFromExistingText(const Vector<CompositionUnderline>&, uns igned compositionStart, unsigned compositionEnd); 58 void setCompositionFromExistingText(const Vector<CompositionUnderline>&, uns igned compositionStart, unsigned compositionEnd);
60 // Inserts the text that is being composed as a regular text and returns tru e 59 // Inserts the text that is being composed as a regular text and returns tru e
61 // if composition exists. 60 // if composition exists.
62 bool confirmComposition(); 61 bool confirmComposition();
63 // Inserts the given text string in the place of the existing composition 62 // Inserts the given text string in the place of the existing composition
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 108
110 String composingText() const; 109 String composingText() const;
111 bool insertTextForConfirmedComposition(const String& text); 110 bool insertTextForConfirmedComposition(const String& text);
112 void selectComposition() const; 111 void selectComposition() const;
113 bool setSelectionOffsets(const PlainTextRange&); 112 bool setSelectionOffsets(const PlainTextRange&);
114 }; 113 };
115 114
116 } // namespace blink 115 } // namespace blink
117 116
118 #endif // InputMethodController_h 117 #endif // InputMethodController_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698