third_party/WebKit/Source/core/dom/ScriptRunner.h - Issue 1929493002: Remove unnecessary uses of GarbageCollectedFinalized<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ScriptRunner.h

Issue 1929493002: Remove unnecessary uses of GarbageCollectedFinalized<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add two leftover classes needing same treatment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/ScopedWindowFocusAllowedIndicator.h ('k') | third_party/WebKit/Source/core/dom/ScriptRunner.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ScriptRunner.h

diff --git a/third_party/WebKit/Source/core/dom/ScriptRunner.h b/third_party/WebKit/Source/core/dom/ScriptRunner.h

index fb0bfd8c979b6ba235786a7d586c2e6d87dc1e9b..4c55fcac0511235be8251d799e7225790fcdcdb2 100644

--- a/third_party/WebKit/Source/core/dom/ScriptRunner.h

+++ b/third_party/WebKit/Source/core/dom/ScriptRunner.h

@@ -39,14 +39,13 @@ class Document;

class ScriptLoader;

class WebTaskRunner;

-class CORE_EXPORT ScriptRunner final : public GarbageCollectedFinalized<ScriptRunner> {

+class CORE_EXPORT ScriptRunner final : public GarbageCollected<ScriptRunner> {

WTF_MAKE_NONCOPYABLE(ScriptRunner);

public:

static ScriptRunner* create(Document* document)

{

return new ScriptRunner(document);

}

- ~ScriptRunner();

enum ExecutionType { ASYNC_EXECUTION, IN_ORDER_EXECUTION };

void queueScriptForExecution(ScriptLoader*, ExecutionType);