third_party/WebKit/Source/platform/LifecycleContextTest.cpp - Issue 1929493002: Remove unnecessary uses of GarbageCollectedFinalized<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/LifecycleContextTest.cpp

Issue 1929493002: Remove unnecessary uses of GarbageCollectedFinalized<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add two leftover classes needing same treatment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/SQLStatement.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/Filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/LifecycleContextTest.cpp

diff --git a/third_party/WebKit/Source/platform/LifecycleContextTest.cpp b/third_party/WebKit/Source/platform/LifecycleContextTest.cpp

index 8835ab96d485d5ec37c05e12f7c71b17a5392a27..19c8c3dc234506e4d34f7f05a1bbdc02a8b481c3 100644

--- a/third_party/WebKit/Source/platform/LifecycleContextTest.cpp

+++ b/third_party/WebKit/Source/platform/LifecycleContextTest.cpp

@@ -47,7 +47,7 @@ public:

}

};

-class TestingObserver final : public GarbageCollectedFinalized<TestingObserver>, public LifecycleObserver<DummyContext, TestingObserver, DummyContext> {

+class TestingObserver final : public GarbageCollected<TestingObserver>, public LifecycleObserver<DummyContext, TestingObserver, DummyContext> {

USING_GARBAGE_COLLECTED_MIXIN(TestingObserver);

public:

static TestingObserver* create(DummyContext* context)