third_party/WebKit/Source/platform/graphics/filters/Filter.h - Issue 1929493002: Remove unnecessary uses of GarbageCollectedFinalized<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/Filter.h

Issue 1929493002: Remove unnecessary uses of GarbageCollectedFinalized<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add two leftover classes needing same treatment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/LifecycleContextTest.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/Filter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/Filter.h

diff --git a/third_party/WebKit/Source/platform/graphics/filters/Filter.h b/third_party/WebKit/Source/platform/graphics/filters/Filter.h

index 48bffcf3efbdc634e7c6d91ae7d8984b66a4bde6..790e6c183459e41b732a5a45894b0e6964006c37 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/Filter.h

+++ b/third_party/WebKit/Source/platform/graphics/filters/Filter.h

@@ -33,7 +33,7 @@ namespace blink {

class SourceGraphic;

class FilterEffect;

-class PLATFORM_EXPORT Filter final : public GarbageCollectedFinalized<Filter> {

+class PLATFORM_EXPORT Filter final : public GarbageCollected<Filter> {

WTF_MAKE_NONCOPYABLE(Filter);

public:

enum UnitScaling {

@@ -44,7 +44,6 @@ public:

static Filter* create(const FloatRect& referenceBox, const FloatRect& filterRegion, float scale, UnitScaling);

static Filter* create(float scale);

- ~Filter();

DECLARE_TRACE();

float scale() const { return m_scale; }