third_party/WebKit/Source/modules/webaudio/AudioBuffer.h - Issue 1929493002: Remove unnecessary uses of GarbageCollectedFinalized<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBuffer.h

Issue 1929493002: Remove unnecessary uses of GarbageCollectedFinalized<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add two leftover classes needing same treatment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationDispatcher.h ('k') | third_party/WebKit/Source/modules/webdatabase/SQLStatement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioBuffer.h

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBuffer.h b/third_party/WebKit/Source/modules/webaudio/AudioBuffer.h

index ec8ebfec369b2810b906c095e0348c53ef109a01..a3b8ba1398afad60a60bbb673d444e97046ca3e8 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioBuffer.h

+++ b/third_party/WebKit/Source/modules/webaudio/AudioBuffer.h

@@ -42,7 +42,7 @@ namespace blink {

class AudioBus;

class ExceptionState;

-class MODULES_EXPORT AudioBuffer final : public GarbageCollectedFinalized<AudioBuffer>, public ScriptWrappable {

+class MODULES_EXPORT AudioBuffer final : public GarbageCollected<AudioBuffer>, public ScriptWrappable {

DEFINE_WRAPPERTYPEINFO();

public:

static AudioBuffer* create(unsigned numberOfChannels, size_t numberOfFrames, float sampleRate);

@@ -75,11 +75,11 @@ public:

}

private:

+ explicit AudioBuffer(AudioBus*);

static DOMFloat32Array* createFloat32ArrayOrNull(size_t length);

-protected:

AudioBuffer(unsigned numberOfChannels, size_t numberOfFrames, float sampleRate);

- explicit AudioBuffer(AudioBus*);

bool createdSuccessfully(unsigned desiredNumberOfChannels) const;

float m_sampleRate;