Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: third_party/WebKit/Source/modules/webdatabase/SQLStatement.cpp

Issue 1929493002: Remove unnecessary uses of GarbageCollectedFinalized<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add two leftover classes needing same treatment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 51
52 SQLStatement::SQLStatement(Database* database, SQLStatementCallback* callback, 52 SQLStatement::SQLStatement(Database* database, SQLStatementCallback* callback,
53 SQLStatementErrorCallback* errorCallback) 53 SQLStatementErrorCallback* errorCallback)
54 : m_statementCallback(callback) 54 : m_statementCallback(callback)
55 , m_statementErrorCallback(errorCallback) 55 , m_statementErrorCallback(errorCallback)
56 { 56 {
57 if (hasCallback() || hasErrorCallback()) 57 if (hasCallback() || hasErrorCallback())
58 InspectorInstrumentation::asyncTaskScheduled(database->getExecutionConte xt(), "SQLStatement", this); 58 InspectorInstrumentation::asyncTaskScheduled(database->getExecutionConte xt(), "SQLStatement", this);
59 } 59 }
60 60
61 SQLStatement::~SQLStatement()
62 {
63 }
64
65 DEFINE_TRACE(SQLStatement) 61 DEFINE_TRACE(SQLStatement)
66 { 62 {
67 visitor->trace(m_backend); 63 visitor->trace(m_backend);
68 visitor->trace(m_statementCallback); 64 visitor->trace(m_statementCallback);
69 visitor->trace(m_statementErrorCallback); 65 visitor->trace(m_statementErrorCallback);
70 } 66 }
71 67
72 void SQLStatement::setBackend(SQLStatementBackend* backend) 68 void SQLStatement::setBackend(SQLStatementBackend* backend)
73 { 69 {
74 m_backend = backend; 70 m_backend = backend;
(...skipping 28 matching lines...) Expand all
103 if (errorCallback) 99 if (errorCallback)
104 callbackError = errorCallback->handleEvent(transaction, SQLError::cr eate(*error)); 100 callbackError = errorCallback->handleEvent(transaction, SQLError::cr eate(*error));
105 } else if (callback) { 101 } else if (callback) {
106 callbackError = !callback->handleEvent(transaction, m_backend->sqlResult Set()); 102 callbackError = !callback->handleEvent(transaction, m_backend->sqlResult Set());
107 } 103 }
108 104
109 return callbackError; 105 return callbackError;
110 } 106 }
111 107
112 } // namespace blink 108 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698